Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double check huggingface backend, apparently does not get passed temperature parameter correctly #15

Closed
davidschlangen opened this issue Nov 8, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@davidschlangen
Copy link
Contributor

(As reported by Jonathan) - backend complains about temperature parameter. The other backends do get (or at least are supposed) to get this parameter when called, so need to go back and check this.

@davidschlangen davidschlangen added the bug Something isn't working label Nov 8, 2023
@Gnurro
Copy link
Contributor

Gnurro commented Nov 8, 2023

In theory the current code should work as intended - I will test this along with testing the local models and report back if there's an actual issue.
This may just be due to the transformers generate method being rather bloated and allowing too many potentially conflicting arguments to be passed. In that case, simply turning off the transformers warnings would 'solve' the issue. See huggingface/transformers#22405 (comment) :

We are aware that our .generate() has too many options and too little checks/examples, we are working on it 🤗

@Gnurro
Copy link
Contributor

Gnurro commented Nov 18, 2023

Temperature is set properly - it's logged now, showing that it's set to 0.0 as intended.

@phisad phisad closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants