Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHI7 index #70

Closed
kylepjohnson opened this issue Feb 5, 2015 · 4 comments
Closed

Add PHI7 index #70

kylepjohnson opened this issue Feb 5, 2015 · 4 comments

Comments

@kylepjohnson
Copy link
Member

This is an easy job. Someone just needs to extend what I've done for PHI5 and TLG.

https://github.com/kylepjohnson/cltk/blob/master/cltk/corpus/utils/formatter.py

@coderbhupendra
Copy link
Contributor

@kylepjohnson i did this but i dont know if this is what you wanted, please see the gist:
https://gist.github.com/coderbhupendra/6fa0b52e4cc3d8869344

I have just copy pasted code of phi5 for phi7, and made assemble_phi7_works_filepaths() and assemble_phi7_author_filepaths() in formatter.py . I have used same same punctuation for phi7 ,if rm_period is true (line #132). And please uncomment the line #17 ,#18 i.e importing PHI7_WORKS_INDEX.
One important thing do i need to make phi7_index.py like phi5_index.pyfrom somewhere, please tell me i will do it.

@kylepjohnson
Copy link
Member Author

Hi @coderbhupendra , I appreciate the hustle, but please hold off on this one. It's not super hard, however we need a Greek and Latin language expert to work on this.

@D-K-E
Copy link
Contributor

D-K-E commented Jan 17, 2017

@kylepjohnson Anything I can help with the greek side of things ?

@kylepjohnson
Copy link
Member Author

@D-K-E Im just getting back from a long vacation. Yes, if you find a copy of the PHI7, take a look at the indices in it. They're really ugly, but making a modern index to these would be really valuable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants