Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Graph degree helpers to new Algorithm\Degree #29

Merged
merged 5 commits into from Jun 6, 2013
Merged

Conversation

clue
Copy link
Member

@clue clue commented May 28, 2013

  • Move Graph degree helpers to new Algorithm\Degree
  • 100% code coverage
  • Documentation / changelog

Refs #27.

@clue
Copy link
Member Author

clue commented May 28, 2013

Remove [WIP] marker, now that all tasks are completed.

@clemens-tolboom, care to review and merge?

@clue
Copy link
Member Author

clue commented May 28, 2013

Sorry, missed moving Graph::isBalanced(), my bad! Adding [WIP] marker again..

@clue
Copy link
Member Author

clue commented May 28, 2013

Removed WIP marker again. Ready for review.

use Fhaculty\Graph\Graph;
use Fhaculty\Graph\Vertex;
use Fhaculty\Graph\Exception\UnexpectedValueException;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to have some explanation about what a Degree is!

Please add some documentation preferably with some refs to wikipedia

@clue
Copy link
Member Author

clue commented Jun 1, 2013

Thanks for the review! Added some documentation and links to wikipedia and rebased on current master. Care to take another look and merge?

clue added a commit that referenced this pull request Jun 6, 2013
Move Graph degree helpers to new Algorithm\Degree
@clue clue merged commit 9362a40 into master Jun 6, 2013
@clue clue deleted the move-algo-degree branch June 6, 2013 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants