Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Graph balance helpers to new Algorithm\Balance #30

Merged
merged 5 commits into from Jun 6, 2013

Conversation

clue
Copy link
Member

@clue clue commented May 28, 2013

  • Move Graph balance helpers to new Algorithm\Balance
  • 100% code coverage
  • Documentation / changelog

Also refs #27.

@clue
Copy link
Member Author

clue commented May 28, 2013

Remove [WIP] marker, now that all tasks are completed.

@clemens-tolboom, care to review and merge?

use Fhaculty\Graph\Algorithm\Base;
use Fhaculty\Graph\Graph;
use Fhaculty\Graph\Vertex;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some class documentation would help but checking out http://en.wikipedia.org/wiki/Directed_graph#Indegree_and_outdegree which has the wording 'balanced digraph' is not helping that much.

Is there a way to help future coders to fix bugs by some form of documentation? Otherwise this is as good to go for me :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a hard time finding some links on balanced flow networks...

The balanced digraph you're talking about refers to its indegee/outdegree and should be located in the Algorithm\Degree (see PR #29).

clue added a commit that referenced this pull request Jun 6, 2013
Move Graph balance helpers to new Algorithm\Balance
@clue clue merged commit 6f905a4 into master Jun 6, 2013
@clue clue deleted the move-algo-balance branch June 6, 2013 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants