Remove unneeded algorithm alias definitions #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's not clear what algoritms where aliased. This should be in the commit message I guess. |
|
The algorithms are listed in the CHANGELOG.md here: https://github.com/clue/graph/pull/31/files#diff-0 Do you think it makes sense to also include this info in the commit message and rewrite the history? Personally, I don't think it's likely this is going to be noticed in the history as it would have expanded beyond the first line in the commit message and it's unlikely anybody is going to look for the info there? |
clue
added a commit
that referenced
this pull request
Jun 6, 2013
Remove unneeded algorithm alias definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unneeded algorithm alias definitions to reduce complexity, improve testability and avoid tight coupling.
Refs #27.
Ready for review.