Updated graphViz to work on OS X

[onigoetz]

on Mac OS X the way to open a file with the default handler is "open"

I added a switch to reflect this

[clue]

Thanks for the PR! I don't have a Mac to test against, but according to the manpages this addition looks good 👍

May I ask you to re-format it as an if-elseif-else-statement instead and format according to PSR-2?

Imho at some point in the future we should consider removing this logic from this library and check if we can add an external dependency. In the meantime, I'd like to merge this PR as-is :)

[clemens-tolboom]

I should test this as I have a mac.

Do we have a guide how to hit this code?

[onigoetz]

Hi,

okay I'll reformat it.

@clemens-tolboom I tested it using https://github.com/clue/graph-composer it worked perfectly after the change

[clue]

Do we have a guide how to hit this code?

Minimal test code:

$graph = new Graph();
$v1 = $graph->createVertex(1);

$graphviz = new GraphViz($graph);
$graphviz->display();

Should be executed via CLI (php test.php).

If your "image viewer" pops up, everything works fine.

[clue]

Thanks for the update! Code looks good to me 👍

Waiting for confirmation from @clemens-tolboom.

[clemens-tolboom]

I can confirm this PR works. Nice fix.

I learned about https://help.github.com/articles/checking-out-pull-requests-locally and needed a small test tweak. Not sure why :(

<?php
require 'vendor/autoload.php';

$graph = new Fhaculty\Graph\Graph();
$v1 = $graph->createVertex(1);

$graphviz = new Fhaculty\Graph\GraphViz($graph);
$graphviz->display();

[clue]

Thanks for the confirmation, code merged!

Yeah, my test case was written under the assumption that the required imports are present :) By using fully-qualified class names, you no longer need those imports.