Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to Response last effective Request or URI object #129

Closed
olegbaturin opened this issue Apr 2, 2019 · 3 comments
Closed

Add to Response last effective Request or URI object #129

olegbaturin opened this issue Apr 2, 2019 · 3 comments

Comments

@olegbaturin
Copy link

I can't get latest effective URL after some redirects from the Response object.

https://www.php.net/manual/en/function.curl-getinfo.php
CURLINFO_EFFECTIVE_URL

@clue
Copy link
Owner

clue commented Apr 3, 2019

@olegbaturin Thanks for reporting, I agree that this feature makes sense 👍

Any suggestions API-wise? The response API is defined by PSR-7. guzzle/guzzle#1166 might be relevant here.

@olegbaturin
Copy link
Author

Effective URI is a part of Response, so you can extend PSR-7 ResponseInterface by getEffectiveUri() method. Latest URI object available in the Request object in the Transaction::onResponse() method.

@clue
Copy link
Owner

clue commented Jul 12, 2020

Thanks for bringing this up! I have to close this one as per #177 now that future development will focus on https://github.com/reactphp/http instead. If you feel this makes sense to port over, please file a new ticket over in the new repo and I'm happy to help review this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants