Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cancellation of redirected requests #99

Closed
clue opened this issue Apr 26, 2018 · 0 comments · Fixed by #110
Closed

Fix cancellation of redirected requests #99

clue opened this issue Apr 26, 2018 · 0 comments · Fixed by #110

Comments

@clue
Copy link
Owner

clue commented Apr 26, 2018

While working on an implementation for clue/reactphp-mq#6, I noticed that some requests do no seem to be cancelled properly, i.e. they keep running despite their promises being cancelled. A similar issues came up in clue/reactphp-mq#7 as it relies on this project for its example. It turns out that this affects cancellation of requests that are issued after the initial request is successfully completed (i.e. redirected requests). Cancellation of operations that have been started instantly worked as expected.

This will eventually also be addressed upstream via reactphp/promise#99, but it's currently not decided when this version will be tagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant