Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an endpoint to fetch the overall ranked colleges by NIRF. #126

Closed
nikhil25803 opened this issue Oct 16, 2022 · 10 comments
Closed

Add an endpoint to fetch the overall ranked colleges by NIRF. #126

nikhil25803 opened this issue Oct 16, 2022 · 10 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest This issue is for hacktoberfest.

Comments

@nikhil25803
Copy link
Member

Description

Notes

  • This is the list of overall colleges ranked by NIRF.
  • Build an endpoint to fetch this data.
  • Set the path as /all/nirf

Screenshots

No response

Additional information

No response

@nikhil25803 nikhil25803 added enhancement New feature or request good first issue Good for newcomers hacktoberfest This issue is for hacktoberfest. labels Oct 16, 2022
@srini047
Copy link

Hi team, I would like to work on this issue.

@nikhil25803
Copy link
Member Author

Sure @srini047, go ahead.

@nikhil25803
Copy link
Member Author

Hey @srini047, any updates?

@srini047
Copy link

Hey, @nikhil25803 sorry for the inconvenience. I currently have my internals scheduled which ends tomorrow. I will update the progress tomorrow.

@srini047
Copy link

@nikhil25803 I have a small doubt.

While I was trying to add a /all/nirf endpoint I came to know that it already exists in the code.

https://github.com/Clueless-Community/collegeAPI/blob/main/main.py#L86-L95

Is my understanding correct? If not correct I would love to hear it.

@nikhil25803
Copy link
Member Author

Hey @srini047, change that endpoint to /all. And name your as /all/nirf

@srini047
Copy link

Hey, @nikhil25803 shocked to see that the endpoint /all/nirf already exists in the main.py file.

@nikhil25803
Copy link
Member Author

Hey, @nikhil25803 shocked to see that the endpoint /all/nirf already exists in the main.py file.

I quotes earlier... Change that endpoint to /all and add your new endpoint as /all/nirf

@srini047
Copy link

Hey, @nikhil25803 shocked to see that the endpoint /all/nirf already exists in the main.py file.

I quotes earlier... Change that endpoint to /all and add your new endpoint as /all/nirf

/all endpoint too already exists.

@nikhil25803
Copy link
Member Author

Yes, @srini047 👀
Thanks for letting me know and extremely sorry for the inconvinience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest This issue is for hacktoberfest.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants