Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bulk import of whitelist, admin and banlist #441

Closed
wants to merge 10 commits into from

Conversation

jake-87
Copy link
Contributor

@jake-87 jake-87 commented Dec 10, 2021

No description provided.

@jake-87
Copy link
Contributor Author

jake-87 commented Dec 10, 2021

At the moment I have the ban reason as "bulk import"; should it also be imported from the file? It would complicate the creation of a ban list, but could be useful to a banned user.

@Hornwitser
Copy link
Member

Usernames don't have spaces in them so you could separate the name and reason with that.

@jake-87
Copy link
Contributor Author

jake-87 commented Dec 10, 2021

@Hornwitser Should be ready for review.

@Hornwitser
Copy link
Member

This is missing a way to do it through the web interface.

Copy link
Member

@Danielv123 Danielv123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. We should absolutely have the same functionality available in the web interface, whether in this PR or its own.

packages/ctl/ctl.js Outdated Show resolved Hide resolved
@jake-87
Copy link
Contributor Author

jake-87 commented Dec 10, 2021

I’d be happy add the webui in this PR, however it may be a few days.

@psihius psihius marked this pull request as draft December 15, 2021 07:42
@psihius psihius added the WIP label Dec 15, 2021
@psihius
Copy link
Collaborator

psihius commented Dec 15, 2021

@jake-87 converted it to draft, press ze button when it's ready for review :)

@jake-87
Copy link
Contributor Author

jake-87 commented Dec 22, 2021

All this needs is a way to refresh the user table so the bulk imports show up, and it's done, as far as I can tell.

@psihius
Copy link
Collaborator

psihius commented Dec 22, 2021

@psihius psihius closed this Dec 22, 2021
@psihius psihius reopened this Dec 22, 2021
@psihius
Copy link
Collaborator

psihius commented Dec 22, 2021

All this needs is a way to refresh the user table so the bulk imports show up, and it's done, as far as I can tell.

You probably need an event/message for that to send out, so the systems grab it from the websocket message bus.
Also, make sure tests don't fail :)

Bonus would be adding tests for this functionality.

@jake-87
Copy link
Contributor Author

jake-87 commented Dec 22, 2021

Apologies, forgot to run final tests after removing personal stuff. I'll see what I can do in terms of the event.

packages/ctl/ctl.js Outdated Show resolved Hide resolved
packages/ctl/ctl.js Outdated Show resolved Hide resolved
@Danielv123 Danielv123 linked an issue Dec 31, 2021 that may be closed by this pull request
@jake-87
Copy link
Contributor Author

jake-87 commented May 10, 2022

I am still working on this. Unfortunately the documentation for the link system is less than optimal, and I am having a hard time understanding the code, so I can't give a decent estimate on when the web interface will be finished.

@psihius
Copy link
Collaborator

psihius commented May 10, 2022

@jake-87 ask in Discord? We can also improve the docs this way :)

@jake-87 jake-87 closed this Sep 27, 2022
@jake-87
Copy link
Contributor Author

jake-87 commented Sep 27, 2022

I'm not going to be able to finish this. Apologies. Feel free to take & merge the CLI code, but the link interface is not well documented enough for me to be able to understand it, and while I appreciate the discord's existence, in my mind it is not a good enough replacement for docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bulk import of adminlist/banlist/whitelist
4 participants