-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added bulk import of whitelist, admin and banlist #441
Conversation
At the moment I have the ban reason as "bulk import"; should it also be imported from the file? It would complicate the creation of a ban list, but could be useful to a banned user. |
Usernames don't have spaces in them so you could separate the name and reason with that. |
8770f1f
to
c6898ed
Compare
@Hornwitser Should be ready for review. |
This is missing a way to do it through the web interface. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. We should absolutely have the same functionality available in the web interface, whether in this PR or its own.
I’d be happy add the webui in this PR, however it may be a few days. |
@jake-87 converted it to draft, press ze button when it's ready for review :) |
All this needs is a way to refresh the user table so the bulk imports show up, and it's done, as far as I can tell. |
|
You probably need an event/message for that to send out, so the systems grab it from the websocket message bus. Bonus would be adding tests for this functionality. |
Apologies, forgot to run final tests after removing personal stuff. I'll see what I can do in terms of the event. |
I am still working on this. Unfortunately the documentation for the link system is less than optimal, and I am having a hard time understanding the code, so I can't give a decent estimate on when the web interface will be finished. |
@jake-87 ask in Discord? We can also improve the docs this way :) |
I'm not going to be able to finish this. Apologies. Feel free to take & merge the CLI code, but the link interface is not well documented enough for me to be able to understand it, and while I appreciate the discord's existence, in my mind it is not a good enough replacement for docs. |
No description provided.