Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ua/arp use in new IPaddr2 #171

Closed
dmuhamedagic opened this issue Nov 8, 2012 · 2 comments
Closed

ua/arp use in new IPaddr2 #171

dmuhamedagic opened this issue Nov 8, 2012 · 2 comments
Milestone

Comments

@dmuhamedagic
Copy link
Contributor

The following code looks wrong to me, because even on infiniband if it's an IPv6 address, we should use send_ua, right? @kskmori: do you agree?

806 if is_infiniband; then
807 run_send_ib_arp
808 elif [ $FAMILY = "inet" ];then
809 if [ -x $SENDARP ]; then
810 run_send_arp
811 fi
812 else
813 if [ -x $SENDUA ]; then
814 run_send_ua
815 fi
816 fi

@kskmori
Copy link

kskmori commented Nov 9, 2012

Yes, I would agree. I was missing that path. But I don't have any infiniband devices around and I've never tested if send_ua works on IPoIB properly. It should work if IPv6addr RA has been working on infiniband of course, but I'd appreciate if someone could test it.

Thanks,

@dmuhamedagic
Copy link
Contributor Author

OK, fixed now. I'm not sure if I'll be able to test it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants