Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocf-tester assumes that agent is implemented using sh/bash #312

Closed
mrichmon opened this issue Sep 23, 2013 · 2 comments
Closed

ocf-tester assumes that agent is implemented using sh/bash #312

mrichmon opened this issue Sep 23, 2013 · 2 comments
Milestone

Comments

@mrichmon
Copy link

The OCF Resource Agent Developer Guide at http://www.linux-ha.org/doc/dev-guides/ra-dev-guide.html states that "An OCF compliant resource agent can be implemented in any programming language. The API is not language specific. However, most resource agents are implemented as shell scripts, which is why this guide primarily uses example code written in shell language."

The current implementation of the ocf-tester invokes the tested ra script with constructs like (eg line 214):

bash /path/to/resourceagent validate-all | cd /usr/share/resource-agents && $METADATA_LINT)

Presumably this should be something more like:

(/path/to/resourceagent validate-all) | cd /usr/share/resource-agents && $METADATA_LINT)

To remove the assumption that the resource agent is implemented in sh or bash.

@mrichmon
Copy link
Author

mrichmon commented Oct 2, 2013

If bash is not necessary, then why does the command "ocf-tester" break when invoked with resource agents that are implemented in anything other than bash?

@dmuhamedagic
Copy link
Contributor

Hmm, did you see the patch in the pull request #317? Isn't that what was this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants