Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "--skip" or "--exclude" option #12

Open
murgatroid99 opened this issue Oct 13, 2017 · 3 comments
Open

Add a "--skip" or "--exclude" option #12

murgatroid99 opened this issue Oct 13, 2017 · 3 comments

Comments

@murgatroid99
Copy link

I would like to use this library, but one of the packages in my packages directory can't be installed locally, which is making the script as a whole fail. It would be great if I could just use something like --skip directory_name to not touch that entire directory.

@clux
Copy link
Owner

clux commented Oct 13, 2017

Hey, yeah, that is a sensible request. It's a bit problematic as there's already an option to pass multiple search directories, and a --skip dir wouldn't necessarily know which of these to filter in without requiring full paths (or you filter all the folders). A global --exclude pathfilter would be acceptable though.

Bit busy myself atm, but will merge a sensible PR with tests 😄
If you separate your folders into ones that work and ones that don't, you'd avoid this problem entirely though.

@murgatroid99
Copy link
Author

Well, the search directories are expected to be relative to the current directory. What if the --skip directories were also relative to the current directory? Then there wouldn't be any ambiguity when filtering.

@clux
Copy link
Owner

clux commented Oct 15, 2017

Yeah, you'd have to take out the leading directory part before doing the filtering down inside the handling for each repo dir, which is a bit awkward, but that could also work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants