Make xmp_set_position consistently clear pattern break/jump vars #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
xmp_set_position
/xmp_next_position
/et al. do not consistently clear the pattern break and jump variables in the player flow struct, meaning if these functions are called between this effect being used and the next row playing, the first row of the position set byxmp_set_position
/etc. will play and then the pattern break or pattern jump will immediately take effect. Believe it or not, this was actually causing an audio bug in a MegaZeux game due to some unfortunate timing.This patch simply makes these functions clear the relevant pattern flow variables whenever the player position is modified. It might also be necessary to clear
f->loop_chn
andf->rowdelay
(not entirely sure).