Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] $CMDER_ROOT/config/user_profile.sh not sourced #2771

Closed
4 tasks done
thomasWos opened this issue Oct 24, 2022 · 6 comments · Fixed by #2779
Closed
4 tasks done

[Bug] $CMDER_ROOT/config/user_profile.sh not sourced #2771

thomasWos opened this issue Oct 24, 2022 · 6 comments · Fixed by #2779
Assignees

Comments

@thomasWos
Copy link

Version Information

Cmder version: v1.3.20
Operating system: Microsoft Windows 10 Enterprise - Version 10.0.19044 Build 19044

Cmder Edition

Cmder Full (with Git)

Description of the issue

Wanted to use the lastest release,
but I noticed that with bash sessions, $CMDER_ROOT/config/user_profile.sh is not sourced.

How to reproduce

No response

Additional context

No response

Checklist

  • I have read the documentation.
  • I have searched for similar issues and found none that describe my issue.
  • I have reproduced the issue on the latest version of Cmder.
  • I am certain my issues are not related to ConEmu, Clink, or other third-party tools that Cmder uses.
@daxgames
Copy link
Member

I see it too. Oddly not seeing it on code in master. Try this unreleased build: https://ci.appveyor.com/api/buildjobs/lr56ti1hv4qpopyv/artifacts/build%2Fcmder.zip

@daxgames
Copy link
Member

daxgames commented Nov 6, 2022

The issue here is that the scripts/build.ps1 script does not appear to be copying %CMDER_ROOT%\vendor\cmder.sh to %CMDER_ROOT%\vendor\git-for-windows\etc\profile.d\cmder.sh

Looking at it now.

@DRSDavidSoft
Copy link
Contributor

DRSDavidSoft commented Nov 6, 2022

@daxgames I can see it too, I think the blame's on me.

The script is actually doing its job, the problem is that (I think) the file is being ignored when packing into 7z, since I made a change that the packignore file is now being performed recursively -- though, I don't see why vendor\cmder.sh is matching against vendor\git-for-windows\etc\profile.d\cmder.sh as well. Yikes, sorry about that! 😬

If you look closely, the git-prompt.sh is also being ignored in the vendor\git-for-windows\etc\profile.d as well. I'm super sorry and embarrassed that such a thing happened, I needed to perform more tests.

Well, now I need to find a solution that would ignore the specified files in the correct directory, without removing the recursive flag as it'll break building the packages if not pushd'd into the right directory.

Will update soon.


Update: Fixed this issue in #2779

@daxgames Thanks for looking into this, as I was unaware of it happening

@daxgames
Copy link
Member

daxgames commented Nov 6, 2022

@DRSDavidSoft no biggee. I am sure we have all introduced bugs.

@DRSDavidSoft DRSDavidSoft self-assigned this Nov 6, 2022
@thomasWos
Copy link
Author

Thanks guys for the fix.
Do you plan to do a new release?
Cheers

@DRSDavidSoft
Copy link
Contributor

@thomasWos There are a couple of other fixes that still need to be done in order to make a new release, but in the meantime, you can download the most recent build (including these fixes) directly from AppVeyor here:

https://ci.appveyor.com/project/cmderdev/cmder/builds/45293395/artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants