Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Version meta information has not been updated in the 1.3.21 release #2801

Closed
4 tasks done
m2u-84 opened this issue Dec 21, 2022 · 7 comments · Fixed by #2804
Closed
4 tasks done

[Bug] Version meta information has not been updated in the 1.3.21 release #2801

m2u-84 opened this issue Dec 21, 2022 · 7 comments · Fixed by #2804
Assignees

Comments

@m2u-84
Copy link

m2u-84 commented Dec 21, 2022

Version Information

Cmder version: 1.3.21
Operating system: Windows 11 22H2 x64

Cmder Edition

Cmder Mini

Description of the issue

I just updated to the latest version (1.3.21) of the cmder Mini release and noticed, that the version info has not been raised. The version file in the ZIP root as well as the EXE meta info are still showing 1.3.20 for me (1.3.20.151 to be exact). I also checked the full version but it has the same issue. This is what I see with the latest files:

grafik

How to reproduce

  1. Download latest full / mini release
  2. Check “Version …” file → it is named incorrectly with the old version number
  3. Open the Cmder.exe properties dialog in Windows → it is reporting the old version number as file and product version

Additional context

No response

Checklist

  • I have read the documentation.
  • I have searched for similar issues and found none that describe my issue.
  • I have reproduced the issue on the latest version of Cmder.
  • I am certain my issues are not related to ConEmu, Clink, or other third-party tools that Cmder uses.
@DRSDavidSoft
Copy link
Contributor

DRSDavidSoft commented Dec 21, 2022

Thanks for reporting the bug! It appears that the packaged file was uploaded before making a git tag, which is our system for including the version file.

image

This is not a bug, but rather an accident made while publishing Cmder. We'll fix it by replacing the ZIP files with updated ones containing the right version info file.

Good catch!


Update: I believe we'll avoid editing the ZIP file and make a new release instead. For anyone interested, please read the follow-ups at: #2818 (comment)

@daxgames
Copy link
Member

daxgames commented Dec 21, 2022

We should cut a new release so chocolatey can ingest the change. Otherwise you have to ask them to manually create a new package. Ask me how I know. 🤔

@DRSDavidSoft
Copy link
Contributor

Hopefully if the package maintainers give us access, I can automate some parts so whenever a new version is released, it'll auto update on package managers

@MartiUK
Copy link
Member

MartiUK commented Dec 21, 2022

The current GitHub workflow doesn't build on tags, which may explain the mismatch.

@daxgames
Copy link
Member

daxgames commented Dec 21, 2022

Simply replacing the zip files on a release cause the chocolatey issue. It is more of an issue with a functional bug fix less important here.

They trigger on a release creation.

@chrisant996
Copy link
Contributor

chrisant996 commented Jul 23, 2023

This is marked closed, but the issue still exists. Or at least, the files in the download link claim to be 1.3.20 (not .21).

@DRSDavidSoft
Copy link
Contributor

@chrisant996 You're right, answered in the duplicate issue here:

#2818 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants