New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orleans Messaging Delivery Guarantees #14

Closed
gabikliot opened this Issue Apr 30, 2015 · 7 comments

Comments

Projects
None yet
2 participants
@gabikliot

gabikliot commented Apr 30, 2015

Hi

Thanks for putting this http://christophermeiklejohn.com/orleans.html up.
I would lime to ask you to correct one inaccuracy in your description. Orleans Messaging Delivery Guarantees is at most once, not at least once, as was written (by mistake) in our paper. Here is a more detailed explanation: http://dotnet.github.io/orleans/Runtime-Implementation-Details/Messaging-Delivery-Guarantees.html
Sorry for creating this confusion in the paper in the first place.

@cmeiklejohn

This comment has been minimized.

Show comment
Hide comment
@cmeiklejohn

cmeiklejohn May 2, 2015

Owner

Addressed by 1cacaae.

Owner

cmeiklejohn commented May 2, 2015

Addressed by 1cacaae.

@cmeiklejohn

This comment has been minimized.

Show comment
Hide comment
@cmeiklejohn

cmeiklejohn May 2, 2015

Owner

Oops, I meant fe79fbb.

Owner

cmeiklejohn commented May 2, 2015

Oops, I meant fe79fbb.

@cmeiklejohn cmeiklejohn closed this May 2, 2015

@gabikliot

This comment has been minimized.

Show comment
Hide comment
@gabikliot

gabikliot May 2, 2015

Sorry, but this is still wrong: "Orleans provides at-most-once message delivery, by resending messages that were not acknowledged after a configurable timeout".
This is dichotomy. At most once means you do not resend.

The correct sentence would be:
"By default Orleans provides at-most-once message delivery. In addition, only if configured to do resends, Orleans will resend messages that were not acknowledged after a configurable timeout, thus providing at least once message delivery".

gabikliot commented May 2, 2015

Sorry, but this is still wrong: "Orleans provides at-most-once message delivery, by resending messages that were not acknowledged after a configurable timeout".
This is dichotomy. At most once means you do not resend.

The correct sentence would be:
"By default Orleans provides at-most-once message delivery. In addition, only if configured to do resends, Orleans will resend messages that were not acknowledged after a configurable timeout, thus providing at least once message delivery".

@cmeiklejohn

This comment has been minimized.

Show comment
Hide comment
@cmeiklejohn

cmeiklejohn May 3, 2015

Owner

My apologies. I conflated the paper description with the guarantees, assuming that you retried using a unique identifier to enforce the at-most-once guarantee. I read the Microsoft page and now understand that a message may not be delivered unless configured to retry under a given timeout.

So, to make sure I understand correctly, if you use timeouts a message will be delivered under the at-least-once guarantee, given some messages might be delivered, acknowledgement dropped/delayed, and retransmitted?

Owner

cmeiklejohn commented May 3, 2015

My apologies. I conflated the paper description with the guarantees, assuming that you retried using a unique identifier to enforce the at-most-once guarantee. I read the Microsoft page and now understand that a message may not be delivered unless configured to retry under a given timeout.

So, to make sure I understand correctly, if you use timeouts a message will be delivered under the at-least-once guarantee, given some messages might be delivered, acknowledgement dropped/delayed, and retransmitted?

@cmeiklejohn

This comment has been minimized.

Show comment
Hide comment
@cmeiklejohn

cmeiklejohn May 3, 2015

Owner

I made the following changes here 45dd8f8. Let me know if you think this is correct.

Owner

cmeiklejohn commented May 3, 2015

I made the following changes here 45dd8f8. Let me know if you think this is correct.

@cmeiklejohn cmeiklejohn reopened this May 3, 2015

@gabikliot

This comment has been minimized.

Show comment
Hide comment
@gabikliot

gabikliot May 4, 2015

Hi. The wording in http://christophermeiklejohn.com/papers/2015/05/03/orleans.html is correct now.

, if you use timeouts a message will be delivered under the at-least-once guarantee, given some messages might be delivered, acknowledgement dropped/delayed, and retransmitted?

All messages have timeout. Always. All messages are delivered by default under at most once.

gabikliot commented May 4, 2015

Hi. The wording in http://christophermeiklejohn.com/papers/2015/05/03/orleans.html is correct now.

, if you use timeouts a message will be delivered under the at-least-once guarantee, given some messages might be delivered, acknowledgement dropped/delayed, and retransmitted?

All messages have timeout. Always. All messages are delivered by default under at most once.

@cmeiklejohn

This comment has been minimized.

Show comment
Hide comment
@cmeiklejohn

cmeiklejohn May 4, 2015

Owner

OK; thank you.

Owner

cmeiklejohn commented May 4, 2015

OK; thank you.

@cmeiklejohn cmeiklejohn closed this May 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment