Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same Jacobian? #13

Closed
tsarikahin opened this issue May 30, 2024 · 1 comment
Closed

Same Jacobian? #13

tsarikahin opened this issue May 30, 2024 · 1 comment

Comments

@tsarikahin
Copy link

tsarikahin commented May 30, 2024

Question

Thx a lot for the repo first of all.

My question would be about the Helmholtz problem (https://github.com/cmgcds/fastvpinns/blob/main/examples/forward_problems_2d/complex_mesh/helmholtz2d/main_helmholtz.py)

Helmholtz problem has two components of the residual loss; x and y contributions, requiring two components of Jacobian (J_x and J_y) as Kharizmi's implementation as well. However, you don't introduce the components of Jacobian. Or do I miss a point?

@thivinanandh
Copy link
Collaborator

The two components of jacobians calculated in 1D is multiplied to get a single jacobian value at a given quadrature point in a 2D space. This jacobian value is used to convert the test functions from reference domain to the actual domain. however, in fastVPINNs implementation, these calculations are performed internally within the FE module and the test function and its gradients are transfered to the actual domain, before being used in calculation of loss.

please go through the implementation section of the fastVPINNs paper for more clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants