Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do you use different number of queries as default setting for estimating gradient in Sign-OPT and SVM-OPT? (200 vs 100) #8

Open
machanic opened this issue Feb 22, 2021 · 0 comments

Comments

@machanic
Copy link

machanic commented Feb 22, 2021

Dear Minhao Cheng:
When I check the code, I found the K (which is used for estimating the gradient of θ), is set different in Sign-OPT and SVM-OPT?
100 vs 200
I think this is not fair for comparing Sign-OPT and SVM-OPT
This is the code in def sign_grad_v1, 200 is the default value.

K = self.k # 200 random directions (for estimating the gradient)

K = self.k # 200 random directions (for estimating the gradient)

and in

X = np.zeros((dim, K))

K = 100 as the default parameter of the def sign_grad_svm function, which does not pass in any parameter?
Should I set all K to100 and redo my experiments for fair comparison of Sign-OPT and SVM-OPT in my paper?
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant