Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal upgrades #75

Closed
cmhughes opened this issue Jul 3, 2017 · 3 comments
Closed

Internal upgrades #75

cmhughes opened this issue Jul 3, 2017 · 3 comments
Labels
implemented implemented tag means that either an enhancement or feature request has been implemented, or bugfix internal concerns 'under the hood' considerations; not usually user focused

Comments

@cmhughes
Copy link
Owner

cmhughes commented Jul 3, 2017 •
edited

75.1: The argument regexp needs updating; at the moment there is a lot of duplication.

75.2: I'd also like to explore an Else.pm object.

75.3: I think that the BlankLines.pm could actually be subsumed into ModifyLineBreaks.pm. Possibly.

75.4: I'd like to explore the http://search.cpan.org/~mschilli/Log-Log4perl-1.49/lib/Log/Log4perl.pm module for logging.
@cmhughes cmhughes added the internal concerns 'under the hood' considerations; not usually user focused label Jul 3, 2017
@cmhughes
Copy link
Owner Author

75.2 is resolved as of 79a6009

@cmhughes cmhughes mentioned this issue Jul 11, 2017
Closed
@cmhughes
Copy link
Owner Author

75.4 is implemented as of 4056e1f

@cmhughes
Copy link
Owner Author

At this point, I'm not convinced the duplication in the arguments regexp can be removed.

Separately, I don't wish to merge BlankLines.pm at this point. I'm going to label this issue as implemented, perhaps to be revisited in the future.

@cmhughes cmhughes added the implemented implemented tag means that either an enhancement or feature request has been implemented, or bugfix label Sep 24, 2017
@cmhughes cmhughes mentioned this issue Jan 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
implemented implemented tag means that either an enhancement or feature request has been implemented, or bugfix internal concerns 'under the hood' considerations; not usually user focused
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cmhughes