Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

READ returned more bytes than requested #6

Open
eXeDK opened this issue Jun 4, 2017 · 5 comments
Open

READ returned more bytes than requested #6

eXeDK opened this issue Jun 4, 2017 · 5 comments

Comments

@eXeDK
Copy link

eXeDK commented Jun 4, 2017

I'm having issues with READ returning bigger packets than the client requested. Both using Transmit and FileZilla on MacOS.

I'm using the package as used in the example with files of size around 10 megabytes.

Is this something you have experienced yourself?

Best Regards
Thomas

@cmrigney
Copy link
Owner

cmrigney commented Jun 4, 2017

Hi Thomas, I don't believe I've ever noticed this issue. Is it causing file corruption?

@eXeDK
Copy link
Author

eXeDK commented Jun 4, 2017

It's causing my client to give up the transfer. I'll investigate further in the morning. Just wanted to hear if you had ever noticed it before.

@eXeDK
Copy link
Author

eXeDK commented Jun 5, 2017

For me all files above 32k (32768) bytes fails when downloading. Upload works fine.
64k files fails as well.

@eXeDK
Copy link
Author

eXeDK commented Jun 5, 2017

Seems like you want to send 32k (or whatever the client asks for) packets but that the packets sent are all of the full file length. Looking at line 202 of node-sftp-s3.js and forward

@cmrigney
Copy link
Owner

cmrigney commented Jun 7, 2017

Thanks, I think I can look into this next week. If you happen to fix it, I'll gladly accept a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants