Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated ES get functions in Alignment/CommonAlignmentAlgorithm #44

Closed
mmusich opened this issue Oct 21, 2021 · 4 comments · Fixed by cms-sw/cmssw#35861
Closed

Deprecated ES get functions in Alignment/CommonAlignmentAlgorithm #44

mmusich opened this issue Oct 21, 2021 · 4 comments · Fixed by cms-sw/cmssw#35861
Assignees

Comments

@mmusich
Copy link
Contributor

mmusich commented Oct 21, 2021

From cms-sw/cmssw#35711 integration tests

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-17-2300/src/Alignment/CommonAlignmentAlgorithm/plugins/SiPixelLorentzAngleCalibration.cc:170:3: warning: function 'SiPixelLorentzAngleCalibration::beginRun' calls function 'edm::eventsetup::EventSetupRecord::get<edm::ESHandle<SiPixelLorentzAngle> >' with argument of type 'const std::string' with argument of type 'edm::ESHandle<SiPixelLorentzAngle>'. Direct call of function EventSetupRecord::get(ESHandle&) is deprecated and should be replaced with a call to EventSetup::getHandle(ESGetToken&). To use ESGetToken see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#In_ED_module To get data with the token see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#Getting_data_from_EventSetup_wit [deprecated.ESRecordGetChecker]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-17-2300/src/Alignment/CommonAlignmentAlgorithm/plugins/SiPixelLorentzAngleCalibration.cc:206:7: warning: function 'SiPixelLorentzAngleCalibration::derivatives' calls function 'edm::eventsetup::EventSetupRecord::get<edm::ESHandle<MagneticField> >' with argument of type 'edm::ESHandle<MagneticField>'. Direct call of function EventSetupRecord::get(ESHandle&) is deprecated and should be replaced with a call to EventSetup::getHandle(ESGetToken&). To use ESGetToken see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#In_ED_module To get data with the token see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#Getting_data_from_EventSetup_wit [deprecated.ESRecordGetChecker]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-17-2300/src/Alignment/CommonAlignmentAlgorithm/plugins/SiStripBackplaneCalibration.cc:191:3: warning: function 'SiStripBackplaneCalibration::derivatives' calls function 'edm::eventsetup::EventSetupRecord::get<edm::ESHandle<SiStripLatency> >' with argument of type 'edm::ESHandle<SiStripLatency>'. Direct call of function EventSetupRecord::get(ESHandle&) is deprecated and should be replaced with a call to EventSetup::getHandle(ESGetToken&). To use ESGetToken see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#In_ED_module To get data with the token see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#Getting_data_from_EventSetup_wit [deprecated.ESRecordGetChecker]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-17-2300/src/Alignment/CommonAlignmentAlgorithm/plugins/SiStripBackplaneCalibration.cc:201:9: warning: function 'SiStripBackplaneCalibration::derivatives' calls function 'edm::eventsetup::EventSetupRecord::get<edm::ESHandle<MagneticField> >' with argument of type 'edm::ESHandle<MagneticField>'. Direct call of function EventSetupRecord::get(ESHandle&) is deprecated and should be replaced with a call to EventSetup::getHandle(ESGetToken&). To use ESGetToken see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#In_ED_module To get data with the token see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#Getting_data_from_EventSetup_wit [deprecated.ESRecordGetChecker]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-17-2300/src/Alignment/CommonAlignmentAlgorithm/plugins/SiStripBackplaneCalibration.cc:209:9: warning: function 'SiStripBackplaneCalibration::derivatives' calls function 'edm::eventsetup::EventSetupRecord::get<edm::ESHandle<SiStripLorentzAngle> >' with argument of type 'const std::string' with argument of type 'edm::ESHandle<SiStripLorentzAngle>'. Direct call of function EventSetupRecord::get(ESHandle&) is deprecated and should be replaced with a call to EventSetup::getHandle(ESGetToken&). To use ESGetToken see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#In_ED_module To get data with the token see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#Getting_data_from_EventSetup_wit [deprecated.ESRecordGetChecker]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-17-2300/src/Alignment/CommonAlignmentAlgorithm/plugins/SiStripBackplaneCalibration.cc:398:5: warning: function 'SiStripBackplaneCalibration::checkBackPlaneCorrectionInput' calls function 'edm::eventsetup::EventSetupRecord::get<edm::ESHandle<SiStripBackPlaneCorrection> >' with argument of type 'const std::string' with argument of type 'edm::ESHandle<SiStripBackPlaneCorrection>'. Direct call of function EventSetupRecord::get(ESHandle&) is deprecated and should be replaced with a call to EventSetup::getHandle(ESGetToken&). To use ESGetToken see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#In_ED_module To get data with the token see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#Getting_data_from_EventSetup_wit [deprecated.ESRecordGetChecker]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-17-2300/src/Alignment/CommonAlignmentAlgorithm/plugins/SiStripBackplaneCalibration.cc:405:7: warning: function 'SiStripBackplaneCalibration::checkBackPlaneCorrectionInput' calls function 'edm::eventsetup::EventSetupRecord::get<edm::ESHandle<SiStripBackPlaneCorrection> >' with argument of type 'const std::string' with argument of type 'edm::ESHandle<SiStripBackPlaneCorrection>'. Direct call of function EventSetupRecord::get(ESHandle&) is deprecated and should be replaced with a call to EventSetup::getHandle(ESGetToken&). To use ESGetToken see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#In_ED_module To get data with the token see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#Getting_data_from_EventSetup_wit [deprecated.ESRecordGetChecker]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-17-2300/src/Alignment/CommonAlignmentAlgorithm/plugins/SiStripLorentzAngleCalibration.cc:185:3: warning: function 'SiStripLorentzAngleCalibration::beginRun' calls function 'edm::eventsetup::EventSetupRecord::get<edm::ESHandle<SiStripLorentzAngle> >' with argument of type 'const std::string' with argument of type 'edm::ESHandle<SiStripLorentzAngle>'. Direct call of function EventSetupRecord::get(ESHandle&) is deprecated and should be replaced with a call to EventSetup::getHandle(ESGetToken&). To use ESGetToken see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#In_ED_module To get data with the token see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#Getting_data_from_EventSetup_wit [deprecated.ESRecordGetChecker]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-17-2300/src/Alignment/CommonAlignmentAlgorithm/plugins/SiStripLorentzAngleCalibration.cc:216:3: warning: function 'SiStripLorentzAngleCalibration::derivatives' calls function 'edm::eventsetup::EventSetupRecord::get<edm::ESHandle<SiStripLatency> >' with argument of type 'edm::ESHandle<SiStripLatency>'. Direct call of function EventSetupRecord::get(ESHandle&) is deprecated and should be replaced with a call to EventSetup::getHandle(ESGetToken&). To use ESGetToken see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#In_ED_module To get data with the token see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#Getting_data_from_EventSetup_wit [deprecated.ESRecordGetChecker]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-17-2300/src/Alignment/CommonAlignmentAlgorithm/plugins/SiStripLorentzAngleCalibration.cc:225:9: warning: function 'SiStripLorentzAngleCalibration::derivatives' calls function 'edm::eventsetup::EventSetupRecord::get<edm::ESHandle<MagneticField> >' with argument of type 'edm::ESHandle<MagneticField>'. Direct call of function EventSetupRecord::get(ESHandle&) is deprecated and should be replaced with a call to EventSetup::getHandle(ESGetToken&). To use ESGetToken see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#In_ED_module To get data with the token see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#Getting_data_from_EventSetup_wit [deprecated.ESRecordGetChecker]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-10-17-2300/src/Alignment/CommonAlignmentAlgorithm/plugins/SiStripLorentzAngleCalibration.cc:400:3: warning: function 'SiStripLorentzAngleCalibration::effectiveThickness' calls function 'edm::eventsetup::EventSetupRecord::get<edm::ESHandle<SiStripBackPlaneCorrection> >' with argument of type 'const std::string' with argument of type 'edm::ESHandle<SiStripBackPlaneCorrection>'. Direct call of function EventSetupRecord::get(ESHandle&) is deprecated and should be replaced with a call to EventSetup::getHandle(ESGetToken&). To use ESGetToken see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#In_ED_module To get data with the token see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#Getting_data_from_EventSetup_wit [deprecated.ESRecordGetChecker]
@tvami tvami added this to To do in CMS AlCaDB project via automation Oct 21, 2021
@tvami
Copy link
Contributor

tvami commented Oct 21, 2021

Hi @bbilin could you please take care of this?

@bbilin
Copy link

bbilin commented Oct 21, 2021

Hi @tvami yes I could, but definitely not this week. This should be fixed "before" the pre5 is closed, right?

@tvami
Copy link
Contributor

tvami commented Oct 21, 2021

Hi @bbilin, yes, indeed that was the plan. As you know there is a reshuffling of releases, so I think finishing this next week will still be fine.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 29, 2021

as cms-sw/cmssw#35861 is integrated this can be closed.

@mmusich mmusich closed this as completed Oct 29, 2021
CMS AlCaDB project automation moved this from In progress to Done Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants