Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More SiPixel ES get() calls #50

Closed
tvami opened this issue Nov 5, 2021 · 4 comments · Fixed by cms-sw/cmssw#36016
Closed

More SiPixel ES get() calls #50

tvami opened this issue Nov 5, 2021 · 4 comments · Fixed by cms-sw/cmssw#36016
Assignees
@mmusich @SanjanaSekhar
Projects
CMS AlCaDB project

Comments

@tvami
Copy link
Contributor

tvami commented Nov 5, 2021 •
edited

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc900/CMSSW_12_2_CMSDEPRECATED_X_2021-11-03-2300/CondFormats/SiPixelObjects

crtl-f for .get( has 8 occurrences
@tvami tvami created this issue from a note in CMS AlCaDB project (To do) Nov 5, 2021
@tvami
Copy link
Contributor Author

tvami commented Nov 5, 2021

I also think this should be under \plugins
Well going even further they should be under CondTools/SiPixel
@mmusich what was the incentive to put these readers under CondFormats?

@mmusich
Copy link
Contributor

mmusich commented Nov 5, 2021

@tvami speaking only for the SiPixelBadFEDChannel* classes, these are mostly sanity check code and should be maintained in the test directory of CondFormats/SiPixelObjects.
Eventually SiPixelFEDChannelContainerFromQualityConverter could be moved.

@mmusich mmusich mentioned this issue Nov 5, 2021
Merged
@mmusich
Copy link
Contributor

mmusich commented Nov 5, 2021

see cms-sw/cmssw#36016

@tvami
Copy link
Contributor Author

tvami commented Nov 6, 2021

resolved in cms-sw/cmssw#36016

@tvami tvami closed this as completed Nov 6, 2021
CMS AlCaDB project automation moved this from To do to Done Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmusich mmusich

@SanjanaSekhar SanjanaSekhar

Labels
None yet
Projects
CMS AlCaDB project
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

migrate to esConsumes several test codes in the SiPixel area mmusich/cmssw
3 participants
@tvami @mmusich @SanjanaSekhar