Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

Task count should be updated as soon as task items are loaded. #170

Closed
DerekStrickland opened this issue Aug 16, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@DerekStrickland
Copy link
Contributor

Describe the bug

If TaskProvider::complete fails, the Task record is never updated with the count of items.

  • TaskProviders share a lifecycle defined by the trait, with one main section of variable logic.
  • Specifically, they vary on how they query for the batch items to process and how they process each item.
  • The TaskProvider trait provides default logic for inserting a Task record when a Task starts, and for updating it with summary statistics and error logging when a Task ends.
  • Unfortunately, if the update at the end fails, the count field never gets updated.
  • This is useful information to have when debugging, and the Task should get updated with a count as soon as that information is available.

To Reproduce

Run any task locally and stop it before it completes.

Expected behavior

The Task document's count field should be updated in each task, as soon as the primary batch query successfully retrieves the set of items to process.

@DerekStrickland DerekStrickland added bug Something isn't working proposed and removed proposed labels Aug 16, 2023
@sbolel
Copy link
Contributor

sbolel commented Sep 18, 2023

⚠️ Repository Decommission Notice: This repository is scheduled to be archived as it has been decommissioned and will no longer be actively maintained. As part of the archival process, we are closing all open issues and pull requests.

@sbolel sbolel closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants