Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O2O Updates #400

Open
mulhearn opened this issue Aug 9, 2016 · 4 comments
Open

O2O Updates #400

mulhearn opened this issue Aug 9, 2016 · 4 comments

Comments

@mulhearn
Copy link
Member

mulhearn commented Aug 9, 2016

The first pass PRs which includes many updates (even since Stage 1) and the Stage 2 L1 menu O2O is here:

The next pass PR will be based (for 80x) this branch in work:

@mulhearn
Copy link
Member Author

mulhearn commented Aug 9, 2016

This has been tested online with CMSSW_8_0_15 and the O2O machinery works. (details to follow).

@kkotov
Copy link

kkotov commented Aug 12, 2016

Verified all payloads:

L1TUtmTriggerMenu - no change wrt. previous version (as expected)

L1TGlobalPrescalesVetos - no change (as expected)

L1TMuonOverlapParams - no change (as expected)

L1TMuonEndcapParams - changed as expected, not yet in use anywhere

L1TMuonBarrelParams - changed, waiting for Giannis to validate it

CaloParams:

  • Layer1 - online DB match the available static configs in all but one entry of inlayer1ECalScaleFactors vector: 1.4931 vs. 1.4932 (must be some harmless rounding issue)
  • Layer2 (new) - validated by comparing agreement between data and emulator for run 276403:
  •  _Jets_ - 100% agreement
    
  •  _Tau_ - expected disagreement, wait for Olivier change 
    
  •  _Eg_ - payloads bitwise 100% agree between online DB and caloStage2Params_2016_v2_2_cfi.py in CMSSW_8_0_9
    

@kkotov
Copy link

kkotov commented Aug 17, 2016

After the cms-sw#15204 PR will be merged, I propose to go forward with two new PRs for my new fullL1TO2Ofor80X and fullL1TO2Ofor81X branches

@koskot77
Copy link

Although, before PRing we can also straighten out some "private" solutions bypassing the need to change CondFormats. For example one of these home-breed solutions: https://github.com/kkotov/cmssw/blob/fullL1TO2Ofor80X/L1Trigger/L1TMuon/interface/L1TMuonGlobalParams_PUBLIC.h do nothing else, but simply substitutes "private" for "public" in https://github.com/kkotov/cmssw/blob/fullL1TO2Ofor80X/CondFormats/L1TObjects/interface/L1TMuonGlobalParams.h#L215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants