Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROOT thread safety patch request #1102

Closed
Dr15Jones opened this issue Oct 17, 2013 · 3 comments
Closed

ROOT thread safety patch request #1102

Dr15Jones opened this issue Oct 17, 2013 · 3 comments
Assignees
@davidlt
Milestone
CMSSW_7_0_0_pre7

Comments

@Dr15Jones
Copy link
Contributor

Two fixes for thread safety issues have been added to ROOT v5-34-00 by @pcanal. The commits are on the v5-00-patches branch and are 98c0d99cf2999575502ed1cd2c5cb233c9062a37 and ca4eea119f2c5fed85665d7e2386cde843fbb554.

I don't know if it would be better to snapshot he whole branch or to just apply these commits to our present version of ROOT. Philippe, do you have any wisdom?
@pcanal
Copy link
Contributor

pcanal commented Oct 18, 2013

Hi Chris,

We are about to cut v5-34/11 based on the branch but there is one test failure in roofit. Since/if you are relying on a specific/different version of roofit anyway, it should be fine to snapshot the whole branch.

Cheers,
Philippe.

@Dr15Jones
Copy link
Contributor Author

This morning Philippe added 4 more fixes which correct mutex ordering problems. We definitely would need to pick those up as well.
9651eb210234ae6fd048f74f9bc4d29989c79f2f
2563f5f047c24201257be3077b1ccaab6117a166
0c40533fe73f8312944ae0f2636ede51b2a33cfb
b5bdb586635f61817bfa14b0eba07ac5014fe602

@ghost ghost assigned davidlt Oct 22, 2013
@davidlt
Copy link
Contributor

davidlt commented Oct 22, 2013

ROOT 5.34.10 + 6 patches: cms-sw/cmsdist#242

Should be in 1400 IB and CMSSW_7_0_0_pre7. Closing.

@davidlt davidlt closed this as completed Oct 22, 2013
@slava77 slava77 mentioned this issue Mar 31, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidlt davidlt

Labels
None yet
Projects
None yet
Milestone
CMSSW_7_0_0_pre7
Development

No branches or pull requests
3 participants
@davidlt @Dr15Jones @pcanal