Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow EventSetup Producers to return std::shared_ptr or std::unique_ptr #13114

Closed
Dr15Jones opened this issue Jan 28, 2016 · 7 comments
Closed

Comments

@Dr15Jones
Copy link
Contributor

The produce methods of ESProducers should be allowed to return std::shared_ptr or std::unique_ptr. At the moment we only support boost::shared_ptr or bare pointers.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 28, 2016

A new Issue was created by @Dr15Jones (Chris Jones).

@davidlange6, @smuzaffar, @Degano, @davidlt, @Dr15Jones can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

assign core

@cmsbuild
Copy link
Contributor

New categories assigned: core

@Dr15Jones,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

@wmtan
Copy link
Contributor

wmtan commented Feb 22, 2016

PR #13158 implements this issue for std::shared_ptr. This issue is still open for std::unique_ptr.

@wmtan
Copy link
Contributor

wmtan commented Feb 23, 2016

PR #13444 implements this issue for std::unique_ptr. This issue should now be resolved.

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants