edmPythonConfigToCppValidation does not support Services

[fwyzard]

running edmPythonConfigToCppValidation over this file FastTimerService_cfi.py

import FWCore.ParameterSet.Config as cms

FastTimerService = cms.Service( "FastTimerService",
    printEventSummary = cms.untracked.bool(True),
    highlightModules  = cms.untracked.VPSet(
        cms.PSet(
            label   = cms.untracked.string('filters'),
            modules = cms.untracked.vstring('sampleFilter', 'sampleFilterMany')
        )
    )
)

results in

Traceback (most recent call last):
  File "/cvmfs/cms.cern.ch/slc7_amd64_gcc630/cms/cmssw/CMSSW_9_0_0/bin/slc7_amd64_gcc630/edmPythonConfigToCppValidation", line 250, in <module>
    raise RuntimeError("No module found in file '"+filename+"'")
RuntimeError: No module found in file 'FastTimerService_cfi.py'

A workaround is simply to change cms.Service to cms.EDProducer.

[cmsbuild]

A new Issue was created by @fwyzard Andrea Bocci.

@davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[Dr15Jones]

assign core

[cmsbuild]

New categories assigned: core

@Dr15Jones,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

[kpedro88]

@Dr15Jones could we just change this line?

cmssw/FWCore/ParameterSet/scripts/edmPythonConfigToCppValidation

Line 246 in 3b3a9c0

if isinstance(config[item], _Module):

to

if isinstance(config[item], _TypedParameterizable):

[Dr15Jones]

You can go ahead and make the pull request.

[kpedro88]

see #19885

[kpedro88]

@Dr15Jones I think this can be closed now

[Dr15Jones]

+1

[cmsbuild]

This issue is fully signed and ready to be closed.