PATPackedCandidateProducer makes copies during sort

[Dr15Jones]

The function used to sort PatCandidates copies the objects in its function arguments:https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/PatAlgos/plugins/PATPackedCandidateProducer.cc#L44

In addition, this is a member function that requires no access to member data so should be marked as static. That is also true for the sort_indexes function.

The proper function signature should be

 static bool candsOrdering(pat::PackedCandidate const& i,pat::PackedCandidate const& j);

[cmsbuild]

A new Issue was created by @Dr15Jones Chris Jones.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[Dr15Jones]

assign reconstruction, analysis

[cmsbuild]

New categories assigned: analysis,reconstruction

@slava77,@perrotta,@monttj you have been requested to review this Pull request/Issue and eventually sign? Thanks

[perrotta]

+1

• Fixed by Do not make copies in PATPackedCandidateProducer, and make two functions static #25668, now merged in the master

[smuzaffar]

fixed