Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLTObjectsMonitor for "objects have different ID" #23200

Closed
fabiocos opened this issue May 14, 2018 · 13 comments
Closed

HLTObjectsMonitor for "objects have different ID" #23200

fabiocos opened this issue May 14, 2018 · 13 comments

Comments

@fabiocos
Copy link
Contributor

The LogWarning message from HLTObjectsMonitor for "objects have different ID" are a source of inflation of the LogError skim (after MemoryChecker), and for this reason #23185 proposes to downgrade it to LogInfo.

Following the comment #23185 (comment) it would be useful to fix the causes for these messages, and restore back the original severity level of them once the problems have been fixed.

@cmsbuild
Copy link
Contributor

A new Issue was created by @fabiocos Fabio Cossutti.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

assign hlt

@cmsbuild
Copy link
Contributor

New categories assigned: hlt

@Martin-Grunewald,@silviodonato,@fwyzard you have been requested to review this Pull request/Issue and eventually sign? Thanks

@Martin-Grunewald
Copy link
Contributor

assign dqm

@cmsbuild
Copy link
Contributor

New categories assigned: dqm

@jfernan2,@vazzolini,@vanbesien,@kmaeshima,@dmitrijus you have been requested to review this Pull request/Issue and eventually sign? Thanks

@fabiocos
Copy link
Contributor Author

@Martin-Grunewald @silviodonato @qliphy is the problem reported here still present?

@Martin-Grunewald
Copy link
Contributor

Looks resolved to me...

@fabiocos
Copy link
Contributor Author

I do still see the LogInfo, it would be interesting to understand whether going back to a LogError is now feasible.

@jfernan2
Copy link
Contributor

+1

@missirol
Copy link
Contributor

I do still see the LogInfo, it would be interesting to understand whether going back to a LogError is now feasible.

I'm new to this issue, but my understanding is that going back to LogError is not a viable option.

The module mentioned in #23185 (i.e. HLTHtMhtFilter) adds by construction trigger objects of 2 different types [1] [2].

This suggests that the check in the DQM module is ill-defined; it assumes a behaviour (i.e. a module returning trigger-objects of only one single type) that not all HLT modules have.

I would suggest to remove that message altogether to avoid further confusion (see #36126).

In any case (whether or not the LogInfo call is removed), I think this issue could be closed.

@fabiocos
Copy link
Contributor Author

@perrotta @qliphy please note the follow-up of this discussion. Are you ok to close this issue, and possibly move further actions to a new one?

@missirol
Copy link
Contributor

+hlt

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants