Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is FWCore/GuiBrowser really needed? #28436

Closed
fabiocos opened this issue Nov 20, 2019 · 8 comments
Closed

Is FWCore/GuiBrowser really needed? #28436

fabiocos opened this issue Nov 20, 2019 · 8 comments

Comments

@fabiocos
Copy link
Contributor

Looking at python scripts not directly probed by the PY3 build, I see we have the package FWCore/GuiBrowsers which looks abandoned since the time of the migration to git,
apart for some basic maintenance. In any case the scripts of this package are not functional at present, and depend on Qt.

@smuzaffar @Dr15Jones before spending further time in view of a python3 migration, is it really needed, and does it make sense to invest work on it, as it seems it does not work since a while and nobody is complaining about it?

@cmsbuild
Copy link
Contributor

A new Issue was created by @fabiocos Fabio Cossutti.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

assign core

@cmsbuild
Copy link
Contributor

New categories assigned: core

@Dr15Jones,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

@Dr15Jones
Copy link
Contributor

@fabiocos this was something 'gifted' to the Core group and we've never had the expertise to maintain it. I'm all for removing it.

@fabiocos
Copy link
Contributor Author

@Dr15Jones @smuzaffar actually, contrary to what I was believing, the tools in this package were function until CMSSW_11_0_0_pre2, and broke in the move top pre3. I suspect #27191 could play a role, I am making a test just to cross check. Whether we want to keep support and the corresponding dependency is another story.

@fabiocos
Copy link
Contributor Author

fabiocos commented Nov 22, 2019

I confirm that #27191 has broken the Gui tools

@smuzaffar
Copy link
Contributor

@fabiocos , we have dropped QT from GCC9 and CentOS8 builds. I would recoomand to drop this.

@fabiocos
Copy link
Contributor Author

removed in #28584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants