[GCC9] Fix fortran warning in GeneratorInterface/PartonShowerVeto

[mrodozov]

There is a warning about uninit var in:
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc900/CMSSW_11_1_X_2020-02-11-2300/GeneratorInterface/PartonShowerVeto
which we'd like to know what init value to use for, to fix the warning.

[cmsbuild]

A new Issue was created by @mrodozov Mircho Rodozov.

@Dr15Jones, @smuzaffar, @silviodonato, @makortel, @davidlange6, @fabiocos can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[makortel]

assign generators

[cmsbuild]

New categories assigned: generators

@alberto-sanchez,@SiewYan,@qliphy,@efeyazgan,@mkirsano,@agrohsje you have been requested to review this Pull request/Issue and eventually sign? Thanks

[agrohsje]

Just to say: I am not aware of anybody using this code.
YCUT should be something say 100 or similar. So we can initialize it with a neg value and throw an error if it is below 0.

[makortel]

Just to say: I am not aware of anybody using this code.

Can this piece of code be removed then?

[silviodonato]

Just to say: I am not aware of anybody using this code.

Can this piece of code be removed then?

@agrohsje

[agrohsje]

@qliphy @mkirsano @SiewYan
checking the history, I don't think this is still used:
https://github.com/cms-sw/cmssw/tree/master/GeneratorInterface/PartonShowerVeto
plotting matching is in genproductions. please comment as well.

[qliphy]

It might still be safe to keep the package for the moment.

To fix the warning, I agree with @agrohsje "YCUT should be something say 100 or similar. So we can initialize it with a neg value and throw an error if it is below 0."

[smuzaffar]

#29757 should resolve this issue.