New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PPC][ARM] Unit test in EventFilter/Utilities failing #32091
Comments
A new Issue was created by @mrodozov Mircho Rodozov. @Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign daq |
Endianness is the same as x86_64 if I remember correctly. Suspicion would be alignment difference wrt. x86_64, so files aren't correctly written or read (or both) on these two platforms . We don't use ARM or PPC currently for DAQ/HLT workflow (don't even have hardware for development and testing) and we can't currently support it. |
It could be clearer to disable the test for non-x86 in the BuildFile. Syntax should be the following (@smuzaffar please correct if necessary) <ifarchitecture name="_amd64_">
<bin file="RunBUFU_t.cpp" name="BUFU_TEST">
<flags TEST_RUNNER_ARGS="/bin/bash EventFilter/Utilities/test RunBUFU.sh"/>
</bin>
</ifarchitecture> The same unit test appears to fail in the same way in CLANG IBs as well (on x86) |
@makortel ok, so it's not architecture specific. I'll investigate and try to reproduce it on my side starting from the master branch. |
@smorovic you can use the CLANG IB, fixing it against it and then we can run the test for Arm and PPC from here
sry if this is redundant :/ |
Thanks @mrodozov , that was useful suggestion. My suspicion is a recent patch introducing changes in the raw data event header format (error is about that header). |
I found the cause: In IOPool/Streamer/interface/FRDEventMessage.h: But in EventFilter/Utilities/src/FedRawDataInputSource.cc (in a few places): There are also checks making sure version is <= "6" in a few places. I'll instead move this into the header file and define as a constant, and then also use it to define std::array length for I'll prepare PRs for 11_2_X/master as well as 11_1_X. |
I created the PR: #32116 It will be followed by 11_1_X backport later. |
this is fixed in Arm, PPC & Clang. closing. thanks @smorovic that was fast :) |
you are welcome, thanks for reporting. |
Unit test:
BUFU_TEST
in EventFilter/Utilities is failing in both Arm and powerpc IBs
with the following:
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_aarch64_gcc820/CMSSW_11_2_X_2020-11-09-2300/unitTestLogs/EventFilter/Utilities#/
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_ppc64le_gcc820/CMSSW_11_2_X_2020-11-06-2300/unitTestLogs/EventFilter/Utilities#/50-50
The text was updated successfully, but these errors were encountered: