Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouping and/or documenting offset used in relvals upgrade workflows #32869

Closed
srimanob opened this issue Feb 10, 2021 · 8 comments
Closed

Grouping and/or documenting offset used in relvals upgrade workflows #32869

srimanob opened this issue Feb 10, 2021 · 8 comments

Comments

@srimanob
Copy link
Contributor

It seems to me that the offsets in Upgrade workflow are picking up randomly (or not?),
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py

Should we try to document them, .e.g. add README, so we collect what are in, and guideline on numbering. And maybe we can try to review and to group them a bit, if it is not too many works, and not create a lot of confusion. I believe it will be better for long term support.

@cmsbuild
Copy link
Contributor

A new Issue was created by @srimanob Phat Srimanobhas.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor

assign pdmv,upgrade

@cmsbuild
Copy link
Contributor

New categories assigned: pdmv,upgrade

@chayanit,@wajidalikhan,@jordan-martins,@kpedro88,@srimanob you have been requested to review this Pull request/Issue and eventually sign? Thanks

@chayanit
Copy link

Hi @srimanob , sounds good to have some documentation so everyone who add things can follow the rules which I actually don't know what the rules are, tbh

@srimanob
Copy link
Contributor Author

srimanob commented Mar 6, 2021

Start to put the document in #33087

@srimanob
Copy link
Contributor Author

srimanob commented Mar 7, 2021

+1

@chayanit
Copy link

chayanit commented Mar 7, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2021

This issue is fully signed and ready to be closed.

@qliphy qliphy closed this as completed Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants