Code still consumes CASTOR tags in Run-3

[tvami]

In #36940
we discovered that the there is still some code that consumes CASTOR tags in Run-3.

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f9c0d/22366/unitTests/src/DQM/Integration/test/TestDQMOnlineClient-ecal_dqm_sourceclient/testing.log
and
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f9c0d/22366/unitTests/src/DQM/Integration/test/TestDQMOnlineClient-hlt_dqm_sourceclient/testing.log

----- Begin Fatal Exception 11-Feb-2022 22:50:25 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing global begin Run run: 344518
   [1] Prefetching for module EcalDQMonitorClient/'ecalMonitorClient'
   [2] Prefetching for EventSetup module CaloGeometryBuilder/''
   [3] Calling method for EventSetup module CastorGeometryFromDBEP/''
   [4] While getting dependent Record from Record CastorGeometryRecord
Exception Message:
No "PCastorRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.

and

----- Begin Fatal Exception 11-Feb-2022 22:50:59 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing global begin Run run: 344518
   [1] Prefetching for module HcalRecHitsAnalyzer/'hltHCALRecHitsAnalyzer'
   [2] Prefetching for EventSetup module CaloGeometryBuilder/''
   [3] Calling method for EventSetup module CastorGeometryFromDBEP/''
   [4] While getting dependent Record from Record CastorGeometryRecord
Exception Message:
No "PCastorRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

[cmsbuild]

A new Issue was created by @tvami Tamas Vami.

@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[tvami]

assign dqm

[cmsbuild]

New categories assigned: dqm

@jfernan2,@ahmad3213,@rvenditti,@emanueleusai,@pbo0,@pmandrik you have been requested to review this Pull request/Issue and eventually sign? Thanks

[tvami]

ping @bsunanda for HCAL and @thomreis for ECAL

[mmusich]

isn't this a duplicate of the first part of #36806 (comment) ?

seems to me something like:

diff --git a/DQM/Integration/python/clients/ecal_dqm_sourceclient-live_cfg.py b/DQM/Integration/python/clients/ecal_dqm_sourceclient-live_cfg.py
index 43bf00c57aa..d2ccb842dd8 100644
--- a/DQM/Integration/python/clients/ecal_dqm_sourceclient-live_cfg.py
+++ b/DQM/Integration/python/clients/ecal_dqm_sourceclient-live_cfg.py
@@ -3,7 +3,8 @@ import FWCore.ParameterSet.Config as cms
 from EventFilter.OnlineMetaDataRawToDigi.tcdsRawToDigi_cfi import * # To monitor LHC status, e.g. to mask trigger primitives quality alarm during Cosmics
 import sys
 
-process = cms.Process("process")
+from Configuration.Eras.Era_Run3_cff import Run3
+process = cms.Process("process", Run3)
 
 unitTest = False
 if 'unitTest=True' in sys.argv:
diff --git a/DQM/Integration/python/clients/hlt_dqm_sourceclient-live_cfg.py b/DQM/Integration/python/clients/hlt_dqm_sourceclient-live_cfg.py
index 19d4a18a757..26462d10dbd 100644
--- a/DQM/Integration/python/clients/hlt_dqm_sourceclient-live_cfg.py
+++ b/DQM/Integration/python/clients/hlt_dqm_sourceclient-live_cfg.py
@@ -1,8 +1,8 @@
 import FWCore.ParameterSet.Config as cms
 
 import sys
-from Configuration.ProcessModifiers.run2_HECollapse_2018_cff import run2_HECollapse_2018
-process = cms.Process("DQM", run2_HECollapse_2018)
+from Configuration.Eras.Era_Run3_cff import Run3
+process = cms.Process("DQM", Run3)
 
 unitTest = False
 if 'unitTest=True' in sys.argv:

on top of #36940 should solve.

[francescobrivio]

This error came up also in the Tier0 replay dmwm/T0#4644 (comment)
with error:

Fatal Exception (Exit Code: 8001)
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 346512 lumi: 104 event: 101103647 stream: 4
   [1] Running path 'dqmoffline_step'
   [2] Prefetching for module TrackingRecoMaterialAnalyser/'materialDumperAnalyzer'
   [3] Prefetching for module DuplicateListMerger/'generalTracks'
   [4] Prefetching for module TrackProducer/'mergedDuplicateTracks'
   [5] Prefetching for module DuplicateTrackMerger/'duplicateTrackCandidates'
   [6] Prefetching for module TrackCollectionMerger/'preDuplicateMergingGeneralTracks'
   [7] Prefetching for module TrackCollectionMerger/'earlyGeneralTracks'
   [8] Prefetching for module TrackProducer/'initialStepTracks'
   [9] Prefetching for module MkFitOutputConverter/'initialStepTrackCandidates'
   [10] Prefetching for module MkFitEventOfHitsProducer/'mkFitEventOfHits'
   [11] Prefetching for module MkFitSiPixelHitConverter/'mkFitSiPixelHits'
   [12] Prefetching for module SiPixelRecHitConverter/'siPixelRecHits'
   [13] Prefetching for module JetCoreClusterSplitter/'siPixelClusters'
   [14] Prefetching for module CandPtrSelector/'jetsForCoreTrackingPreSplitting'
   [15] Prefetching for module FastjetJetProducer/'ak4CaloJetsForTrkPreSplitting'
   [16] Prefetching for EventSetup module CaloGeometryBuilder/''
   [17] Calling method for EventSetup module CastorGeometryFromDBEP/''
   [18] While getting dependent Record from Record CastorGeometryRecord
Exception Message:
No "PCastorRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.

[tvami]

isn't this a duplicate of the first part of #36806 (comment) ?

seems to me something like:

diff --git a/DQM/Integration/python/clients/ecal_dqm_sourceclient-live_cfg.py b/DQM/Integration/python/clients/ecal_dqm_sourceclient-live_cfg.py
index 43bf00c57aa..d2ccb842dd8 100644
--- a/DQM/Integration/python/clients/ecal_dqm_sourceclient-live_cfg.py
+++ b/DQM/Integration/python/clients/ecal_dqm_sourceclient-live_cfg.py
@@ -3,7 +3,8 @@ import FWCore.ParameterSet.Config as cms
 from EventFilter.OnlineMetaDataRawToDigi.tcdsRawToDigi_cfi import * # To monitor LHC status, e.g. to mask trigger primitives quality alarm during Cosmics
 import sys
 
-process = cms.Process("process")
+from Configuration.Eras.Era_Run3_cff import Run3
+process = cms.Process("process", Run3)
 
 unitTest = False
 if 'unitTest=True' in sys.argv:
diff --git a/DQM/Integration/python/clients/hlt_dqm_sourceclient-live_cfg.py b/DQM/Integration/python/clients/hlt_dqm_sourceclient-live_cfg.py
index 19d4a18a757..26462d10dbd 100644
--- a/DQM/Integration/python/clients/hlt_dqm_sourceclient-live_cfg.py
+++ b/DQM/Integration/python/clients/hlt_dqm_sourceclient-live_cfg.py
@@ -1,8 +1,8 @@
 import FWCore.ParameterSet.Config as cms
 
 import sys
-from Configuration.ProcessModifiers.run2_HECollapse_2018_cff import run2_HECollapse_2018
-process = cms.Process("DQM", run2_HECollapse_2018)
+from Configuration.Eras.Era_Run3_cff import Run3
+process = cms.Process("DQM", Run3)
 
 unitTest = False
 if 'unitTest=True' in sys.argv:

on top of #36940 should solve.

Thanks Marco, I submitted this in this PR #36946

[mmusich]

This error came up also in the Tier0 replay dmwm/T0#4644 (comment)
with error:

I think a possible way of investigation is dmwm/T0#4644 (comment).

This smells again like a stale era definition in the T0 configuration, given that Tamas' PR actually tests positively, setting a side the online DQM

[jfernan2]

+1
For the records

[cmsbuild]

This issue is fully signed and ready to be closed.