Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential simplification (and speedup) of Vavilov implementation #37529

Closed
dpiparo opened this issue Apr 11, 2022 · 5 comments · Fixed by #37533
Closed

Potential simplification (and speedup) of Vavilov implementation #37529

dpiparo opened this issue Apr 11, 2022 · 5 comments · Fixed by #37533

Comments

@dpiparo
Copy link
Contributor

dpiparo commented Apr 11, 2022

The construction of the VVIObjF object is responsible for 2.5% of the Phase-2 reconstruction, despite the advanced performance optimizations implemented in the past.
However, it seems that in our code, a simplified version of the constructor could be invoked, with the beta2 and mode parameters set to 1.

@cmsbuild
Copy link
Contributor

A new Issue was created by @dpiparo Danilo Piparo.

@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor

assign reconstruction

@makortel
Copy link
Contributor

type performance-improvements

@cmsbuild
Copy link
Contributor

New categories assigned: reconstruction

@jpata,@slava77,@clacaputo you have been requested to review this Pull request/Issue and eventually sign? Thanks

@mmusich
Copy link
Contributor

mmusich commented Apr 19, 2022

@dpiparo is #37533 along the lines of what you had in mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants