Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$bjs missing from print preview #166

Closed
cmb69 opened this issue Mar 17, 2017 · 2 comments
Closed

$bjs missing from print preview #166

cmb69 opened this issue Mar 17, 2017 · 2 comments
Labels
bug
Milestone
1.7.0

Comments

@cmb69
Copy link
Member

cmb69 commented Mar 17, 2017

See https://cmsimpleforum.com/viewtopic.php?f=10&t=12568
@cmb69 cmb69 added this to the 1.6.10 milestone Mar 17, 2017
@cmb69
Copy link
Member Author

cmb69 commented May 30, 2017

I just tried to do that, and noticed that XH.adaptAdminMenu() throws an error, because the admin menu isn't available in the print preview. As that problem is already resolved in XH 1.7, and since the missing $bjs appears to be a minor issue (nobody really complained), I'm changing the milestone to 1.7.

@cmb69 cmb69 modified the milestones: 1.7, 1.6.10 May 30, 2017
@cmb69 cmb69 added the bug label Jun 18, 2017
@cmb69
Copy link
Member Author

cmb69 commented Jun 18, 2017

I suggest to merge PR #254.

@cmb69 cmb69 modified the milestones: 1.7.0, 1.7 Jun 18, 2017
@cmb69 cmb69 added the voting label Jun 19, 2017
@cmb69 cmb69 closed this as completed in 0383378 Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.7.0
Development

No branches or pull requests
1 participant
@cmb69