Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyMCE5 - replace TinyMCE4 #492

Closed
manu37 opened this issue Feb 16, 2021 · 4 comments
Closed

TinyMCE5 - replace TinyMCE4 #492

manu37 opened this issue Feb 16, 2021 · 4 comments

Comments

@manu37
Copy link
Contributor

manu37 commented Feb 16, 2021

As TinyMCE4 has reached its EOL, it should be replaced by TinyMCE5.

@manu37 manu37 added this to the 1.8 milestone Feb 16, 2021
@manu37 manu37 linked a pull request Feb 16, 2021 that will close this issue
@olape-git
Copy link
Contributor

👍

@manu37 manu37 linked a pull request Feb 22, 2021 that will close this issue
@manu37 manu37 modified the milestones: 1.8, 1.7.5 Feb 22, 2021
@manu37
Copy link
Contributor Author

manu37 commented Mar 3, 2021

TinyMCE5 inits as JSON?
Dies wäre der ideale Moment, um die init files auf JSON umzustellen.
Vorteile:
Der init Code könnte auf seine Gültigkeit geprüft werden und wäre robuster gegen JS Fehler. Diese können abgefangen und als Fehlermeldung ausgegeben werden.
Der init Code kann viel einfacher verarbeitet werden und ist einfacher anzupassen, wenn gewünscht. Theoretisch können gewünschte Settings per Konfigutation eingestellt werden.
Nachteile:
Der JSON Code des init Files sieht etwas anders aus als der JS Literal, wie es tiny.cloud vorschlägt. Das könnte zu kleineren Konfusionen führen, wenn jemand Beispielcode von tiny.cloud kopiert.

{
  "table_advtab": true,
  "table_cell_advtab": true,
  "table_style_by_css": true,
  "image_advtab": true,
  "image_title": true,
  "importcss_append":true,
  "style_formats_autohide": true,
  ....
}

Wie ich sehe, hat das @cmb69 im codeeditor bereits vor Jahren umgesetzt.

Was meint ihr dazu? Thumbs up/down?

@cmb69
Copy link
Member

cmb69 commented Aug 8, 2021

d53633d has added TinyMCE 5, but for 1.7 we need to still ship TinyMCE 4. Anyhow, this can be closed now in favor of PR #507.

@cmb69 cmb69 closed this as completed Aug 8, 2021
@cmb69 cmb69 removed this from the 1.7.5 milestone Aug 8, 2021
@manu37
Copy link
Contributor Author

manu37 commented Aug 9, 2021

d53633d has added TinyMCE 5, but for 1.7 we need to still ship TinyMCE 4. Anyhow, this can be closed now in favor of PR #507.

Why? TinyMCE5 can get rolled out. Default in full install. On updates, the cms config file is unchanged. (TinyMCE4 is still there, could be remarked in deleted_files.txt). The user desides which editor he/she (still) uses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants