Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search may generate superfluous output #54

Closed
cmb69 opened this issue Feb 23, 2017 · 2 comments
Closed

Search may generate superfluous output #54

cmb69 opened this issue Feb 23, 2017 · 2 comments
Milestone

Comments

@cmb69
Copy link
Member

cmb69 commented Feb 23, 2017

Forum discussion

@cmb69 cmb69 added this to the 1.7.0 milestone Feb 23, 2017
@cmb69 cmb69 changed the title evaluate_scripting() may generate superfluous output Search may generate superfluous output May 8, 2017
@cmb69
Copy link
Member Author

cmb69 commented May 8, 2017

While searching the contents all plugin calls (but not CMSimple scriptings) are evaluated. This can result in permanent modifications of several global variables, such as $hjs, $bjs, $e etc., what may yield superfluous and even erroneous output on the search result page. Simple POC: add {{{e('cntwriteto', 'folder', 'foo')}}} to one of the pages, and you get an error message on the search result page, even though the page with the plugin call may not even be part of the search results.

@cmb69
Copy link
Member Author

cmb69 commented May 8, 2017

I suggest to merge PR #237.

@cmb69 cmb69 added the voting label May 8, 2017
@cmb69 cmb69 closed this as completed in eb8e532 May 26, 2017
@cmb69 cmb69 added enhancement and removed voting labels May 26, 2017
@cmb69 cmb69 modified the milestones: 1.7.0rc1, 1.7 May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant