Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyMCE 5 is not shown on the product pages of XHShop #546

Closed
cmb69 opened this issue Nov 6, 2021 · 2 comments
Closed

TinyMCE 5 is not shown on the product pages of XHShop #546

cmb69 opened this issue Nov 6, 2021 · 2 comments
Labels
Milestone

Comments

@cmb69
Copy link
Member

cmb69 commented Nov 6, 2021

Reported by hixi.

Possible solution. I'm not sure, though, whether that might have unwanted side effects. @manu37, could you please have a look.

@cmb69 cmb69 added the bug label Nov 6, 2021
@cmb69 cmb69 added this to the 1.7.6 milestone Nov 6, 2021
@manu37
Copy link
Contributor

manu37 commented Nov 7, 2021

Is this the 1st occurrance we use tinymce5_replace()? This is really a bug. As I see it, on tinymce5_replace() the hole config establish is missing and the solution above solves that. I don't see any problems with this fix.

@cmb69
Copy link
Member Author

cmb69 commented Nov 7, 2021

There are probably only few plugins which call editor_replace(). I only do that in Coco_XH, and that has the same issue (no editor without the fix).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants