You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When properly hit, Vamp rush CD is never reduced. While I'm way too lazy to figure out the fix myself, I assume that the object is not properly given when nothing is passed into the apply_cooldown_override function, when "owner" is required(though owner might be defaulted, not entirely sure). Additionally, it's not even properly set to the right number of 30, as per the original PR's statement of "Reduced to three seconds if landed", whereas the current code(should) set it to 4 seconds.
What's the difference with what should have happened?
Rush cooldown should be set to three seconds, but is defaulted to 6 seconds instead.
How do we reproduce this bug?
Rush normally and miss a target and record time until off CD
Rush a target and land it and record time until off CD
Both are the exact same time.
Issue Bingo
Issue could be reproduced at least once
Issue happened in a recent (less than 7 days ago) round
Picture taken from Diego's original vampire strain PR#955
This was not in fact unused code, this was an error made by either Diego's original vampire strain or Carlacs rework. This is still a bug. I did not notice the PR "Removing dead code", if I did I should have pointed this out, but this was intended by it's original owner, and as far as I am aware, was not intentionally removed by anybody.
Testmerges
#2521, #2776, #2756, #2752, #2753, #2777
Description of the bug
When properly hit, Vamp rush CD is never reduced. While I'm way too lazy to figure out the fix myself, I assume that the object is not properly given when nothing is passed into the apply_cooldown_override function, when "owner" is required(though owner might be defaulted, not entirely sure). Additionally, it's not even properly set to the right number of 30, as per the original PR's statement of "Reduced to three seconds if landed", whereas the current code(should) set it to 4 seconds.
What's the difference with what should have happened?
Rush cooldown should be set to three seconds, but is defaulted to 6 seconds instead.
How do we reproduce this bug?
Issue Bingo
The text was updated successfully, but these errors were encountered: