Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vampire Rush not properly reducing CD if hit #2836

Closed
3 tasks done
Butlerblock opened this issue Mar 14, 2023 · 3 comments
Closed
3 tasks done

Vampire Rush not properly reducing CD if hit #2836

Butlerblock opened this issue Mar 14, 2023 · 3 comments
Labels
Not a Bug help!!!! i shot the enemy and it didnt die

Comments

@Butlerblock
Copy link

Butlerblock commented Mar 14, 2023

Testmerges

#2521, #2776, #2756, #2752, #2753, #2777

Description of the bug

When properly hit, Vamp rush CD is never reduced. While I'm way too lazy to figure out the fix myself, I assume that the object is not properly given when nothing is passed into the apply_cooldown_override function, when "owner" is required(though owner might be defaulted, not entirely sure). Additionally, it's not even properly set to the right number of 30, as per the original PR's statement of "Reduced to three seconds if landed", whereas the current code(should) set it to 4 seconds.

What's the difference with what should have happened?

Rush cooldown should be set to three seconds, but is defaulted to 6 seconds instead.

How do we reproduce this bug?

  1. Rush normally and miss a target and record time until off CD
  2. Rush a target and land it and record time until off CD
  3. Both are the exact same time.

Issue Bingo

@Butlerblock Butlerblock added the Bug Admin events aren't bugs label Mar 14, 2023
@Huffie56 Huffie56 added Needs Reproducing We're not even sure if you know how to do it Bug Admin events aren't bugs and removed Bug Admin events aren't bugs labels Aug 3, 2023
@Huffie56
Copy link
Contributor

Huffie56 commented Aug 3, 2023

fixed by #3300
apparently wiki was wrong and their was unused code that make you think it would reduce CD if hit but it don't ...weird stuff...

@Huffie56 Huffie56 closed this as completed Aug 3, 2023
@Butlerblock
Copy link
Author

image
Picture taken from Diego's original vampire strain PR #955

This was not in fact unused code, this was an error made by either Diego's original vampire strain or Carlacs rework. This is still a bug. I did not notice the PR "Removing dead code", if I did I should have pointed this out, but this was intended by it's original owner, and as far as I am aware, was not intentionally removed by anybody.

@Drulikar
Copy link
Contributor

Drulikar commented Aug 4, 2023

Most recent attempt to add it back that was closed: #2938

Wiki was already updated to reflect this: https://cm-ss13.com/w/index.php?title=Lurker&diff=25517&oldid=24699

As it stands right now, it is working as intended.

@Drulikar Drulikar added Not a Bug help!!!! i shot the enemy and it didnt die and removed Bug Admin events aren't bugs Needs Reproducing We're not even sure if you know how to do it labels Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Not a Bug help!!!! i shot the enemy and it didnt die
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants