Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on naming conventions checker #27

Closed
lmwnshn opened this issue Sep 26, 2019 · 1 comment
Closed

Turn on naming conventions checker #27

lmwnshn opened this issue Sep 26, 2019 · 1 comment
Labels
best-practice Style fixes or refactor in the code base. Mark issues with this.

Comments

@lmwnshn
Copy link
Collaborator

lmwnshn commented Sep 26, 2019

Right now, we're not enforcing terrier-style naming checks on the codebase. We didn't switch this check on early enough, and we don't want to make students go back and fix up their old code only for style. So we'll wait until the semester is over before we enable this check.

Just uncomment these lines.

@lmwnshn lmwnshn added this to the Fall 2020 milestone Sep 26, 2019
@lmwnshn lmwnshn added the best-practice Style fixes or refactor in the code base. Mark issues with this. label Sep 26, 2019
@garrisonhess garrisonhess removed this from the Fall 2020 milestone May 29, 2022
@skyzh
Copy link
Member

skyzh commented Aug 27, 2022

Already resolved.

/Users/skyzh/Work/bustub/src/binder/parser.cpp:43:6: error: invalid case style for function 'test_func' [readability-identifier-naming,-warnings-as-errors]
void test_func() {}
     ^~~~~~~~~
     TestFunc
The files that failed were:
['/Users/skyzh/Work/bustub/src/binder/parser.cpp']
Note that a failing .h file will fail all the .cpp files that include it.

@skyzh skyzh closed this as completed Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
best-practice Style fixes or refactor in the code base. Mark issues with this.
Projects
None yet
Development

No branches or pull requests

3 participants