Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

namespace fixes #16

Closed
apavlo opened this issue Jul 24, 2018 · 0 comments · Fixed by #75
Closed

namespace fixes #16

apavlo opened this issue Jul 24, 2018 · 0 comments · Fixed by #75
Assignees
@mbutrovich
Labels
beginner Good for newcomers. Mark issues with this. best-practice Style fixes or refactor in the code base. Mark issues with this.

Comments

@apavlo
Copy link
Member

apavlo commented Jul 24, 2018 •
edited

  1. Everything should be in the namespace of its subdir. Including common. Do not need to extend to sub-sub-dirs.
  2. May need to write python script for checking namespaces.
@tli2 tli2 added the best-practice Style fixes or refactor in the code base. Mark issues with this. label Jul 31, 2018
@tli2 tli2 assigned tli2 and unassigned lmwnshn and tli2 Aug 3, 2018
@tli2 tli2 added the beginner Good for newcomers. Mark issues with this. label Aug 6, 2018
@mbutrovich mbutrovich mentioned this issue Aug 6, 2018
Merged
@tli2 tli2 closed this as completed in #75 Aug 6, 2018
yangjuns pushed a commit to yangjuns/terrier that referenced this issue Apr 5, 2019
@yashNaN
Merge pull request cmu-db#16 from yash620/yashwn-dev
bd4739a 
Removed heap memory allocation for scan/select header mangling
@wuwenw wuwenw mentioned this issue Jan 29, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mbutrovich mbutrovich

Labels
beginner Good for newcomers. Mark issues with this. best-practice Style fixes or refactor in the code base. Mark issues with this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Misc best practice fixes mbutrovich/noisepage
4 participants
@apavlo @mbutrovich @lmwnshn @tli2