This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
compiled_query_execution command line arg #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of TPL interpretation.
mbutrovich
added
the
in-progress
Codecov Report
@@ Coverage Diff @@
## master #1057 +/- ##
==========================================
- Coverage 80.66% 80.63% -0.03%
==========================================
Files 649 649
Lines 42129 42132 +3
==========================================
- Hits 33983 33973 -10
- Misses 8146 8159 +13
Continue to review full report at Codecov.
|
mbutrovich
added
ready-for-review
lmwnshn
added
ready-to-merge
stephaniewang100
added a commit
to stephaniewang100/terrier-steph
that referenced
this pull request
Aug 14, 2020
* Add Debug Log Timestamps to Python Test Harness (cmu-db#1010) Co-authored-by: Benliang Wang <benlianw@gmail.com> * Add SQL Trace Files to Repository (cmu-db#1025) Co-authored-by: Andy Pavlo <pavlo@cs.brown.edu> * Add Support for ORDER BY column# (cmu-db#964) Co-authored-by: wangguangyuan <wangguangyuan@sensetime.com> Co-authored-by: Matt Butrovich <mbutrovich@users.noreply.github.com> Co-authored-by: Andy Pavlo <pavlo@cs.brown.edu> * Re-enable Microbenchmark Regression Checks (cmu-db#1034) * Fix self joins which use index joins (cmu-db#1022) * [TPL2] Update of execution engine (cmu-db#994) Co-authored-by: Tanuj Nayak <tanujnay112@live.com> Co-authored-by: Matt Butrovich <mbutrovich@users.noreply.github.com> Co-authored-by: Matt Butrovich <mbutrovich@gmail.com> Co-authored-by: Wan Shen Lim <wanshenl@cs.cmu.edu> * Build improvements (cmu-db#1026) * Add support for compiling shared library * mac OS build fix Searches for Brew's clang++ on mac OS, which is required for builds. * Build with dynamic-linking on non-mac OS platforms Supports dynamic linking on non-mac OS platforms, but force-disables it on mac OS. * Make sure that OLTP-Bench results directory names are unique (cmu-db#1015) * Move Limit/Offset Fields to AbstractScanPlanNode (cmu-db#938) Co-authored-by: Matt Butrovich <mbutrovich@users.noreply.github.com> Co-authored-by: Andy Pavlo <pavlo@cs.brown.edu> * Merge Matt's requested changes Implements the changes that Matt requested. * Disable ODR violation detection for asan tests Address sanitizer checks for one-definition-rule violations. This ruins tests. This is technically a bandaid solution, but since the violations don't seem to matter, it's probably the best solution. * Fix ASAN options Avoids overwriting Mac OS ASAN options. * Statically link spdlog An attempt (here goes nothing) at bringing in spdlog as a git submodule and statically linking it. * Cleaner Clang initialization on MacOS Sets the location of Clang on MacOS by reusing existing variables. * Pull submodules from within Jenkinsfile * Just a test commit to try to coerce a proper build. Will revert. Ignore me. * Revert "Explicit instantiation of spdlog template functions (cmu-db#995)" This reverts commit 686eb69. * Update spdlog entry in versions.txt Migrate to remote fetching of spdlog. * Delete spdlog folder Entirely manage spdlog through CMake. * Revert "Just a test commit to try to coerce a proper build. Will revert." This reverts commit d162eae. * Revert "Pull submodules from within Jenkinsfile" This reverts commit ca80090. * Revert changes to .gitmodules * Revert src/CMakeLists.txt * Fetch and (properly) build spdlog * Literally just adding a file named "a" Attempting to make this visible to Jenkins. * Obscure bugfix for Release builds Fixes Release builds for macOS by slightly changing header order. May cause obscure AppleClang segfaults. In fact, this will almost certainly cause a segfault on the Jenkins machine during the build, but here's why I'm submitting this anyway: I've been attempting to debug AppleClang, but after a few hours of debugging, I'm at my wits end. There's a bug somewhere in this call to getRegClassWeight, which causes getRegClassWeight to dereference a null pointer: https://github.com/llvm/llvm-project-staging/blob/f0fd4f3af0acda5068acc5bbe10b3792c41bdfc4/llvm/lib/CodeGen/MachineLICM.cpp#L912 The really weird thing is that for regular Clang, getRegisterClassWeight should be essentially a no-op here--it's a const getter. There's really not much that should be going on unless a null registerclass is being passed, but even then, it shouldn't be crashing *here*. A null registerclass should cause catastrophic failure way earlier. So I'm thinking Apple's fork of Clang does something special here that Clang doesn't do, and that the Jenkins version of AppleClang might not incorporate this new feature, since it runs an older version of the macOS toolchain. * Fix FindClangTools.cmake A long-standing pet peeve of mine is that FindClangTools.cmake doesn't work (at least not on Arch) when clang-{format,tidy} are installed through the system package manager. This fixes that. * Cleaner ThirdPartyToolchain.cmake Removes some unneeded code that used to (but no longer) exists in the codebase. * Suppress clang-format warning We are actually required to keep the includes in this order (at least, spdlog.h MUST be at the top). clang-format is really bothered by this. * Remove stray file. Override compiler on macOS in Jenkinsfile. * Different way to set compiler on macOS. * Revert "Different way to set compiler on macOS." This reverts commit 8a06349 * Fix typo. Co-authored-by: Kevin Geng <khg@andrew.cmu.edu> Co-authored-by: Jordi Gonzalez <jordig@imac1.db.pdl.local.cmu.edu> Co-authored-by: Yao Yu <skyfish.jy@gmail.com> Co-authored-by: Joseph Koshakow <jkosh44@users.noreply.github.com> Co-authored-by: Matt Butrovich <mbutrovich@users.noreply.github.com> Co-authored-by: Andy Pavlo <pavlo@cs.brown.edu> Co-authored-by: Matt Butrovich <mbutrovich@gmail.com> * Revert "Build improvements (cmu-db#1026)" (cmu-db#1036) This reverts commit d31d08e * Fix update counts, run TPCC in end-to-end performance on Jenkins. (cmu-db#1039) * Add execCtxAddRowsAffected builtin. * Fix TrafficCopTest. * Change Jenkinsfile End-to-End Performance to (1) timeout for tatp, (2) run tpcc. Co-authored-by: Wan Shen Lim <wanshenl@cs.cmu.edu> * Refactor Python Test Harness to Improve Extensibility (cmu-db#1024) Co-authored-by: Daniel Biales <bialesdaniel@gmail.com> Co-authored-by: Andy Pavlo <pavlo@cs.brown.edu> * Fix pipeline metrics, clean up some stray includes (cmu-db#1044) * compiled_query_execution command line arg (cmu-db#1057) * Forward declare (operator and expression) translators, fix TPL AstPrettyPrint for array length. (cmu-db#1051) * Fix parallel codegen and parallel scan, force insert/update/delete to be serial. (cmu-db#1056) * Add Support for More than Two Disjunction Predicates (cmu-db#1064) Co-authored-by: Andy Pavlo <pavlo@cs.brown.edu> Co-authored-by: Matt Butrovich <mbutrovich@users.noreply.github.com> * VarlenEntry microbenchmark (cmu-db#1055) * Mini-Runners Update for TPLv2 Engine (cmu-db#1060) * Hyperbolic Trig SQL Functions (cmu-db#1078) Co-authored-by: rohanaggarwal <aggarwal.rohan@yahoo.co.in> Co-authored-by: gautam20197 <gautam20197@gmail.com> Co-authored-by: Preetansh Goyal <preetjee313@gmail.com> Co-authored-by: Matt Butrovich <mbutrovich@users.noreply.github.com> Co-authored-by: benliangw <benliangw@gmail.com> Co-authored-by: Benliang Wang <benlianw@gmail.com> Co-authored-by: Jeff Niu <dniu@andrew.cmu.edu> Co-authored-by: Andy Pavlo <pavlo@cs.brown.edu> Co-authored-by: coco <coconason@gmail.com> Co-authored-by: wangguangyuan <wangguangyuan@sensetime.com> Co-authored-by: Matt Butrovich <mbutrovich@users.noreply.github.com> Co-authored-by: abalakumar083 <30840848+abalakumar083@users.noreply.github.com> Co-authored-by: Wan Shen Lim <wanshen.lim@gmail.com> Co-authored-by: Tanuj Nayak <tanujnay112@live.com> Co-authored-by: Matt Butrovich <mbutrovich@gmail.com> Co-authored-by: Wan Shen Lim <wanshenl@cs.cmu.edu> Co-authored-by: J. Gonzalez <gonzalezjo@users.noreply.github.com> Co-authored-by: Kevin Geng <khg@andrew.cmu.edu> Co-authored-by: Jordi Gonzalez <jordig@imac1.db.pdl.local.cmu.edu> Co-authored-by: Yao Yu <skyfish.jy@gmail.com> Co-authored-by: Joseph Koshakow <jkosh44@users.noreply.github.com> Co-authored-by: Daniel Biales <bialesdaniel@gmail.com> Co-authored-by: wuwenw <55009204+wuwenw@users.noreply.github.com> Co-authored-by: William Zhang <wz2@andrew.cmu.edu> Co-authored-by: rohanaggarwal <aggarwal.rohan@yahoo.co.in> Co-authored-by: gautam20197 <gautam20197@gmail.com> Co-authored-by: Preetansh Goyal <preetjee313@gmail.com>
stephaniewang100
added a commit
to stephaniewang100/terrier-steph
that referenced
this pull request
Aug 14, 2020
* Add Debug Log Timestamps to Python Test Harness (cmu-db#1010) Co-authored-by: Benliang Wang <benlianw@gmail.com> * Add SQL Trace Files to Repository (cmu-db#1025) Co-authored-by: Andy Pavlo <pavlo@cs.brown.edu> * Add Support for ORDER BY column# (cmu-db#964) Co-authored-by: wangguangyuan <wangguangyuan@sensetime.com> Co-authored-by: Matt Butrovich <mbutrovich@users.noreply.github.com> Co-authored-by: Andy Pavlo <pavlo@cs.brown.edu> * Re-enable Microbenchmark Regression Checks (cmu-db#1034) * Fix self joins which use index joins (cmu-db#1022) * [TPL2] Update of execution engine (cmu-db#994) Co-authored-by: Tanuj Nayak <tanujnay112@live.com> Co-authored-by: Matt Butrovich <mbutrovich@users.noreply.github.com> Co-authored-by: Matt Butrovich <mbutrovich@gmail.com> Co-authored-by: Wan Shen Lim <wanshenl@cs.cmu.edu> * Build improvements (cmu-db#1026) * Add support for compiling shared library * mac OS build fix Searches for Brew's clang++ on mac OS, which is required for builds. * Build with dynamic-linking on non-mac OS platforms Supports dynamic linking on non-mac OS platforms, but force-disables it on mac OS. * Make sure that OLTP-Bench results directory names are unique (cmu-db#1015) * Move Limit/Offset Fields to AbstractScanPlanNode (cmu-db#938) Co-authored-by: Matt Butrovich <mbutrovich@users.noreply.github.com> Co-authored-by: Andy Pavlo <pavlo@cs.brown.edu> * Merge Matt's requested changes Implements the changes that Matt requested. * Disable ODR violation detection for asan tests Address sanitizer checks for one-definition-rule violations. This ruins tests. This is technically a bandaid solution, but since the violations don't seem to matter, it's probably the best solution. * Fix ASAN options Avoids overwriting Mac OS ASAN options. * Statically link spdlog An attempt (here goes nothing) at bringing in spdlog as a git submodule and statically linking it. * Cleaner Clang initialization on MacOS Sets the location of Clang on MacOS by reusing existing variables. * Pull submodules from within Jenkinsfile * Just a test commit to try to coerce a proper build. Will revert. Ignore me. * Revert "Explicit instantiation of spdlog template functions (cmu-db#995)" This reverts commit 686eb69. * Update spdlog entry in versions.txt Migrate to remote fetching of spdlog. * Delete spdlog folder Entirely manage spdlog through CMake. * Revert "Just a test commit to try to coerce a proper build. Will revert." This reverts commit d162eae. * Revert "Pull submodules from within Jenkinsfile" This reverts commit ca80090. * Revert changes to .gitmodules * Revert src/CMakeLists.txt * Fetch and (properly) build spdlog * Literally just adding a file named "a" Attempting to make this visible to Jenkins. * Obscure bugfix for Release builds Fixes Release builds for macOS by slightly changing header order. May cause obscure AppleClang segfaults. In fact, this will almost certainly cause a segfault on the Jenkins machine during the build, but here's why I'm submitting this anyway: I've been attempting to debug AppleClang, but after a few hours of debugging, I'm at my wits end. There's a bug somewhere in this call to getRegClassWeight, which causes getRegClassWeight to dereference a null pointer: https://github.com/llvm/llvm-project-staging/blob/f0fd4f3af0acda5068acc5bbe10b3792c41bdfc4/llvm/lib/CodeGen/MachineLICM.cpp#L912 The really weird thing is that for regular Clang, getRegisterClassWeight should be essentially a no-op here--it's a const getter. There's really not much that should be going on unless a null registerclass is being passed, but even then, it shouldn't be crashing *here*. A null registerclass should cause catastrophic failure way earlier. So I'm thinking Apple's fork of Clang does something special here that Clang doesn't do, and that the Jenkins version of AppleClang might not incorporate this new feature, since it runs an older version of the macOS toolchain. * Fix FindClangTools.cmake A long-standing pet peeve of mine is that FindClangTools.cmake doesn't work (at least not on Arch) when clang-{format,tidy} are installed through the system package manager. This fixes that. * Cleaner ThirdPartyToolchain.cmake Removes some unneeded code that used to (but no longer) exists in the codebase. * Suppress clang-format warning We are actually required to keep the includes in this order (at least, spdlog.h MUST be at the top). clang-format is really bothered by this. * Remove stray file. Override compiler on macOS in Jenkinsfile. * Different way to set compiler on macOS. * Revert "Different way to set compiler on macOS." This reverts commit 8a06349 * Fix typo. Co-authored-by: Kevin Geng <khg@andrew.cmu.edu> Co-authored-by: Jordi Gonzalez <jordig@imac1.db.pdl.local.cmu.edu> Co-authored-by: Yao Yu <skyfish.jy@gmail.com> Co-authored-by: Joseph Koshakow <jkosh44@users.noreply.github.com> Co-authored-by: Matt Butrovich <mbutrovich@users.noreply.github.com> Co-authored-by: Andy Pavlo <pavlo@cs.brown.edu> Co-authored-by: Matt Butrovich <mbutrovich@gmail.com> * Revert "Build improvements (cmu-db#1026)" (cmu-db#1036) This reverts commit d31d08e * Fix update counts, run TPCC in end-to-end performance on Jenkins. (cmu-db#1039) * Add execCtxAddRowsAffected builtin. * Fix TrafficCopTest. * Change Jenkinsfile End-to-End Performance to (1) timeout for tatp, (2) run tpcc. Co-authored-by: Wan Shen Lim <wanshenl@cs.cmu.edu> * Refactor Python Test Harness to Improve Extensibility (cmu-db#1024) Co-authored-by: Daniel Biales <bialesdaniel@gmail.com> Co-authored-by: Andy Pavlo <pavlo@cs.brown.edu> * Fix pipeline metrics, clean up some stray includes (cmu-db#1044) * compiled_query_execution command line arg (cmu-db#1057) * Forward declare (operator and expression) translators, fix TPL AstPrettyPrint for array length. (cmu-db#1051) * Fix parallel codegen and parallel scan, force insert/update/delete to be serial. (cmu-db#1056) * Add Support for More than Two Disjunction Predicates (cmu-db#1064) Co-authored-by: Andy Pavlo <pavlo@cs.brown.edu> Co-authored-by: Matt Butrovich <mbutrovich@users.noreply.github.com> * VarlenEntry microbenchmark (cmu-db#1055) * Mini-Runners Update for TPLv2 Engine (cmu-db#1060) * Hyperbolic Trig SQL Functions (cmu-db#1078) Co-authored-by: rohanaggarwal <aggarwal.rohan@yahoo.co.in> Co-authored-by: gautam20197 <gautam20197@gmail.com> Co-authored-by: Preetansh Goyal <preetjee313@gmail.com> Co-authored-by: Matt Butrovich <mbutrovich@users.noreply.github.com> Co-authored-by: benliangw <benliangw@gmail.com> Co-authored-by: Benliang Wang <benlianw@gmail.com> Co-authored-by: Jeff Niu <dniu@andrew.cmu.edu> Co-authored-by: Andy Pavlo <pavlo@cs.brown.edu> Co-authored-by: coco <coconason@gmail.com> Co-authored-by: wangguangyuan <wangguangyuan@sensetime.com> Co-authored-by: Matt Butrovich <mbutrovich@users.noreply.github.com> Co-authored-by: abalakumar083 <30840848+abalakumar083@users.noreply.github.com> Co-authored-by: Wan Shen Lim <wanshen.lim@gmail.com> Co-authored-by: Tanuj Nayak <tanujnay112@live.com> Co-authored-by: Matt Butrovich <mbutrovich@gmail.com> Co-authored-by: Wan Shen Lim <wanshenl@cs.cmu.edu> Co-authored-by: J. Gonzalez <gonzalezjo@users.noreply.github.com> Co-authored-by: Kevin Geng <khg@andrew.cmu.edu> Co-authored-by: Jordi Gonzalez <jordig@imac1.db.pdl.local.cmu.edu> Co-authored-by: Yao Yu <skyfish.jy@gmail.com> Co-authored-by: Joseph Koshakow <jkosh44@users.noreply.github.com> Co-authored-by: Daniel Biales <bialesdaniel@gmail.com> Co-authored-by: wuwenw <55009204+wuwenw@users.noreply.github.com> Co-authored-by: William Zhang <wz2@andrew.cmu.edu> Co-authored-by: rohanaggarwal <aggarwal.rohan@yahoo.co.in> Co-authored-by: gautam20197 <gautam20197@gmail.com> Co-authored-by: Preetansh Goyal <preetjee313@gmail.com> Co-authored-by: benliangw <benliangw@gmail.com> Co-authored-by: Benliang Wang <benlianw@gmail.com> Co-authored-by: Jeff Niu <dniu@andrew.cmu.edu> Co-authored-by: Andy Pavlo <pavlo@cs.brown.edu> Co-authored-by: coco <coconason@gmail.com> Co-authored-by: wangguangyuan <wangguangyuan@sensetime.com> Co-authored-by: Matt Butrovich <mbutrovich@users.noreply.github.com> Co-authored-by: abalakumar083 <30840848+abalakumar083@users.noreply.github.com> Co-authored-by: Wan Shen Lim <wanshen.lim@gmail.com> Co-authored-by: Tanuj Nayak <tanujnay112@live.com> Co-authored-by: Matt Butrovich <mbutrovich@gmail.com> Co-authored-by: Wan Shen Lim <wanshenl@cs.cmu.edu> Co-authored-by: J. Gonzalez <gonzalezjo@users.noreply.github.com> Co-authored-by: Kevin Geng <khg@andrew.cmu.edu> Co-authored-by: Jordi Gonzalez <jordig@imac1.db.pdl.local.cmu.edu> Co-authored-by: Yao Yu <skyfish.jy@gmail.com> Co-authored-by: Joseph Koshakow <jkosh44@users.noreply.github.com> Co-authored-by: Daniel Biales <bialesdaniel@gmail.com> Co-authored-by: wuwenw <55009204+wuwenw@users.noreply.github.com> Co-authored-by: William Zhang <wz2@andrew.cmu.edu> Co-authored-by: rohanaggarwal <aggarwal.rohan@yahoo.co.in> Co-authored-by: gautam20197 <gautam20197@gmail.com> Co-authored-by: Preetansh Goyal <preetjee313@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
compiled_query_executionboolean arg to enable LLVM compilation instead of TPL interpretation. Default is to interpret. Currently doesn't allow for enabling adaptive mode since that doesn't work anyway on short queries due to object life cycle issues.