Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better logging in the indicator runner #1890

Closed
melange396 opened this issue Aug 14, 2023 · 0 comments · Fixed by #1892
Closed

Add better logging in the indicator runner #1890

melange396 opened this issue Aug 14, 2023 · 0 comments · Fixed by #1892
Assignees

Comments

@melange396
Copy link
Contributor

https://github.com/cmu-delphi/covidcast-indicators/blob/main/_delphi_utils_python/delphi_utils/runner.py could have some more detail in its logging.

  • add timing for (ie, around) core indicator method, and validation and flash steps (archive step already has some minimal summary info but could probably be improved)
  • more detail for individual validation failure log messages, like threshold and reference/live values
  • maybe move log line that prints "Completed indicator run" to a core location instead of replicating in each indicator?

and less generally:

  • log around update_cache_file() in delphi_quidel_covidtest because the cache file is getting huge in prod (~180MB as of 2 aug 2023)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants