Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated aes_string call #598

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Replace deprecated aes_string call #598

merged 2 commits into from
Oct 14, 2022

Conversation

krivard
Copy link
Contributor

@krivard krivard commented Oct 10, 2022

Fixes #597

Prep for ggplot2 update. Switching to .data$ syntax as recommended.

@krivard krivard marked this pull request as ready for review October 11, 2022 21:51
capnrefsmmat
capnrefsmmat approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested this manually on the ggplot 3.4.0 release branch. No warnings, no problems (apart from the usual plotting differences between platforms). Thanks for dealing with this

@capnrefsmmat capnrefsmmat merged commit 6eda4b2 into main Oct 14, 2022
@krivard krivard deleted the krivard/ggplot-update branch October 14, 2022 17:58
@capnrefsmmat capnrefsmmat mentioned this pull request Dec 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capnrefsmmat capnrefsmmat capnrefsmmat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with next version of ggplot2
2 participants
@krivard @capnrefsmmat