Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move acquisition deployment off of github-deploy-repo #1042

Open
krivard opened this issue Dec 2, 2022 · 6 comments
Open

Move acquisition deployment off of github-deploy-repo #1042

krivard opened this issue Dec 2, 2022 · 6 comments
Labels
devops building, running, deploying, environment stuff, handy utils, repository-related, engineer QoL, etc refactor Substantial projects to make the code do the same thing, better.

Comments

@krivard
Copy link
Contributor

krivard commented Dec 2, 2022

github-deploy-repo works via a webhook. The webhook is written in PHP, which we are slowly scrubbing from Delphi's active tech stack.

This webhook silently broke after the v4 deployment. While we have developed a fix, a better long-term solution would be to change the deployment mechanism for the acquisition system to something that more closely matches the approaches used by all our other active projects.

@krivard krivard added refactor Substantial projects to make the code do the same thing, better. devops building, running, deploying, environment stuff, handy utils, repository-related, engineer QoL, etc labels Dec 2, 2022
@melange396
Copy link
Collaborator

it looks like the way tests are run by github-deploy-repo is not completely compatible with the way we do it in our current standard development cycle (see this slack thread for some context). if we do not completely move away from github-deploy-repo in the near future, we may consider removing its testing step(s), or at least be cognizant of the fact that they can be unreliable.

@melange396
Copy link
Collaborator

references to "undefx" probably can and should also be removed from the above files too

@korlaxxalrok
Copy link
Contributor

For now we are still heavily reliant on github-deploy-repo to write the various parts of delphi-epidata (via deploy.json) to a filesystem so that the expected import locations and module paths work.

We also still use the webhook functionality, but only in production (and manually deploy to staging).

We can probably make it stop running tests since we do most of that already in Actions CI now, but we'll need to keep it around until we have a different way of getting our bits into an environment that can run them.

A good goal would be to containerize "everything" so that we can start looking at more flexible systems to host and run our jobs, as well as local development rigs and workflows.

@dshemetov
Copy link
Contributor

This comment may be useful when refactoring our repo paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops building, running, deploying, environment stuff, handy utils, repository-related, engineer QoL, etc refactor Substantial projects to make the code do the same thing, better.
Projects
None yet
Development

No branches or pull requests

4 participants