Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed several files in the covidcast signals folder #1476

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

tinatownes
Copy link
Collaborator

Removed -inactive, and renamed quidel files to distinguish covid and flu.

closes|addresses

Summary:

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Removed -inactive, and renamed quidel files to distinguish covid and flu.
@tinatownes tinatownes self-assigned this Jun 14, 2024
Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual changes look good, but I realized that these pages may be linked elsewhere, e.g.. We'd need to update those URLs too to make sure we don't break the links.

Based on the example search results above, this will span multiple repositories, so may be easier for me to do. I think it will affect quidel more than the other pages because the original renaming from, e.g., "safegraph" -> "safegraph-inactive" probably wasn't accompanied by link renaming in other repos.

Copy link

sonarcloud bot commented Jun 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@nmdefries
Copy link
Contributor

Not breaking links to doc pages was easiest by keeping the active (covid) quidel doc file named quidel.md instead of quidel-covid.md; the only other link that needed to be updated was an .../indicator-combination-inactive.html in this repo. No other outdated URLs exist in this repo or other Delphi repos.

@nmdefries nmdefries self-requested a review June 17, 2024 21:32
@nmdefries nmdefries merged commit 27b54fc into dev Jun 17, 2024
7 checks passed
@nmdefries nmdefries deleted the Tina_renaming_inactive_files branch June 17, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants