Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use epidata client in covidcast integration tests #67

Closed
dfarrow0 opened this issue Apr 20, 2020 · 2 comments · Fixed by #1091
Closed

use epidata client in covidcast integration tests #67

dfarrow0 opened this issue Apr 20, 2020 · 2 comments · Fixed by #1091
Assignees
@minhkhul
Labels
Engineering Used to filter issues when synching with Asana good first issue refactor Substantial projects to make the code do the same thing, better.
Projects
Issue tracking for delphi-epidata

Comments

@dfarrow0
Copy link
Contributor

the covidcast integration tests should use the epidata client now that it supports the covidcast endpoints
@dfarrow0 dfarrow0 mentioned this issue Apr 20, 2020
Open
@krivard krivard added refactor Substantial projects to make the code do the same thing, better. good first issue labels Sep 17, 2020
@SumitDELPHI SumitDELPHI added the Engineering Used to filter issues when synching with Asana label Dec 2, 2020
@krivard
Copy link
Contributor

krivard commented Feb 3, 2023

We want to change

https://github.com/cmu-delphi/delphi-epidata/blob/dev/integrations/server/test_covidcast.py#L27-L35

to use Epidata.covidcast(), the same/similar way

delphi-epidata/integrations/server/test_fluview.py

Line 62 in f949439

response = Epidata.fluview('nat', 202020)
uses Epidata.fluview()

@krivard
Copy link
Contributor

krivard commented Feb 3, 2023

Source for the client: https://github.com/cmu-delphi/delphi-epidata/blob/dev/src/client/delphi_epidata.py

@minhkhul minhkhul mentioned this issue Feb 21, 2023
Merged
Issue tracking for delphi-epidata automation moved this from Backlog to Done Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@minhkhul minhkhul

Labels
Engineering Used to filter issues when synching with Asana good first issue refactor Substantial projects to make the code do the same thing, better.
Projects
Issue tracking for delphi-epidata
Done
Milestone
No milestone
4 participants
@krivard @dfarrow0 @SumitDELPHI @minhkhul