[Draft] Attempt to support geo argument #18
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an attempt to support the geo parameter and fix #14. It works fine, but the code looks ugly. I'm not sure that I like going down this path for this package.
Here is the issue: the Covidcast API has multiple ways to specify arguments.
data_source
andsignals
orsignal={source}:{signal}[;...]
geo_type
andgeo_values
orgeo={geo_type}:{geo_values}[;...]
This translates into ugly interfaces for the functions in this package
Optional
(e.g. look at thecall
method I modified)So I'm not sure what to do.