Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Attempt to support geo argument #18

Closed
wants to merge 1 commit into from
Closed

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Aug 18, 2022

Here is an attempt to support the geo parameter and fix #14. It works fine, but the code looks ugly. I'm not sure that I like going down this path for this package.

Here is the issue: the Covidcast API has multiple ways to specify arguments.

  • data_source and signals or signal={source}:{signal}[;...]
  • geo_type and geo_values or geo={geo_type}:{geo_values}[;...]

This translates into ugly interfaces for the functions in this package

  • most arguments become Optional (e.g. look at the call method I modified)
  • lots of validation boilerplate to see which of the above arguments were used
  • argument order doesn't matter which encourages confusion

So I'm not sure what to do.

@dshemetov
Copy link
Contributor Author

Closing as not planned.

@dshemetov dshemetov closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Epidata.covidcast interface does not support the geo=geo_type:geo_values parameter
1 participant